Don't send newlines to the shell from Terminal Chat

[PankajBhojwani]

Summary of the Pull Request

When a multiline code block is clicked in Terminal chat, the first command gets run before the user presses 'Enter'. This commit fixes that by separating the code lines by the delimiter appropriate to the shell (& for cmd, ; for everything else).

Validation Steps Performed

Newlines get replaced with the appropriate delimiter

PR Checklist

• Closes [Terminal Chat] Copying a suggestion with multiple lines is pasted improperly #17939
• Tests added/passed
• Documentation updated
  • If checked, please file a pull request on our docs repo and link it here: #xxx
• Schema updated (if necessary)

[DHowett]

This is in lieu of having good bracketed paste support in conhost and powershell

[lhecker]

I'm a little confused why we don't just remove the \r replacement entirely. \r is what the shell considers to be an "Enter" press so if we send \n delimited strings the shell will treat it as a multi-line paste. If that is correct, then the & / ; replacement seems like the wrong way to solve this.

[PankajBhojwani]

I'm a little confused why we don't just remove the \r replacement entirely. \r is what the shell considers to be an "Enter" press so if we send \n delimited strings the shell will treat it as a multi-line paste. If that is correct, then the & / ; replacement seems like the wrong way to solve this.

Unfortunately the way we send the text to the shell (i.e. via a SendInput action) does not behave well with newlines, which was why this "replace newlines with \r" was here in the first place.

[DHowett]

\r is what the shell considers to be an "Enter" press so if we send \n delimited strings the shell will treat it as a multi-line paste.

cmd has entered the room

[lhecker]

Unfortunately the way we send the text to the shell (i.e. via a SendInput action) does not behave well with newlines, which was why this "replace newlines with \r" was here in the first place.

What was the issue with SendInput? In my testing it work just fine (outside of cmd).

cmd has entered the room

Right, that makes sense.

[PankajBhojwani]

What was the issue with SendInput? In my testing it work just fine (outside of cmd).

#15788. We closed it because we stipulated there should actually be \rs along with the \ns.