Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Windows.Terminal.VisualStudio" to schema #18322

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Add "Windows.Terminal.VisualStudio" to schema #18322

merged 1 commit into from
Dec 13, 2024

Conversation

carlos-zamora
Copy link
Member

Closes #18037

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Schema Things that have to do with the json schema. Product-Terminal The new Windows Terminal. labels Dec 13, 2024
@carlos-zamora
Copy link
Member Author

@DHowett when you get the chance, can you admin merge this please? 🙏

@DHowett DHowett merged commit 8598ed7 into main Dec 13, 2024
12 checks passed
@DHowett DHowett deleted the dev/cazamor/schema/vs-dynamic-profile branch December 13, 2024 20:40
DHowett pushed a commit that referenced this pull request Dec 13, 2024
@carlos-zamora @DHowett
Add "Windows.Terminal.VisualStudio" to schema (#18322)
fc8c6f6 
Closes #18037

(cherry picked from commit 8598ed7)
Service-Card-Id: PVTI_lADOAF3p4s4AmhmszgVq2uo
Service-Version: 1.21
DHowett pushed a commit that referenced this pull request Dec 13, 2024
@carlos-zamora @DHowett
Add "Windows.Terminal.VisualStudio" to schema (#18322)
dc807db 
Closes #18037

(cherry picked from commit 8598ed7)
Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgVq2uw
Service-Version: 1.22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@lhecker lhecker lhecker approved these changes

@DHowett DHowett DHowett approved these changes

Assignees
No one assigned
Labels
Area-Schema Things that have to do with the json schema. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
1.21 Servicing Pipeline
Status: Cherry Picked
1.22 Servicing Pipeline
Status: Cherry Picked
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

settings.json schema rejects valid "disabledProfileSources"
4 participants
@carlos-zamora @DHowett @lhecker @zadjii-msft