Add a switch for exporting settings #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested by #6
twsouthwick
reviewed
Aug 28, 2017
| @@ -208,6 +214,37 @@ static bool SetDefaults(uint[] colorTable) | |||
| return true; | |||
| } | |||
|
|
|||
| static bool ExportCurrentAsIni(string outputPath) | |||
There was a problem hiding this comment.
Since there are multiple ways we may want to export, it would be nice to have some interface we could program against (ie ISchemeExporter in contrast to ISchemeParser) so ini, iterm, etc could be used
There was a problem hiding this comment.
Indeed, exporting to .itermcolors should be possible, not only to .ini
There was a problem hiding this comment.
So as to not back up this code review any longer, I'm going to "Won't Fix" this and link it to the new issue #160.
My goal at this moment is to clear this backlog of pulls. Thanks.
oscarsiauw
reviewed
Nov 21, 2017
tools/ColorTool/ColorTool/Program.cs
Outdated
| } | ||
| else | ||
| { | ||
| Console.WriteLine("Failed to get conosle information."); |
There was a problem hiding this comment.
Typo "conosle" should be "console"
miniksa
added
the
Product-Colortool
carlos-zamora
pushed a commit
that referenced
this pull request
Aug 21, 2020
Add optimization for search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by #6.
colortool -o <filename>will write the current properties to<filename>, in ini file format.