Build a TerminalAppLib and TerminalAppDll separately #2002
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is like a de-refactor of #1164. We're now building TerminalApp _twice_. Once as a lib, and once as a dll. For whatever godforsaken reason, the wapproj project type is a dumpster fire. If we try to build a static lib, then link that into a DLL, the wapproj will absolutely _not_ get all the resources, dlls, xbfs, etc., that we need into the msix. So now we're building TerminalApp twice. Once as a lib, which we'll use for the unittests. Then we'll build it again, for consumption in WindowsTerminal. All the combined files for these two projects are in terminal-app-common.vcxproj, similar to host-common from the host project. This does mean we'll have two pch.h steps for the same code. That's a giant pain, but I think @miniksa is working on that.
TerminalApp is literally the only one I cannot get to work with a shared PCH. So if you're making more of them, you're effectively undoing all the work I'm doing right now to share a PCH among the other things. Why does this have to be done? |
|
thank god |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR into #1948. I couldn't verify that the fix worked on just master, so I branched from the tip of 1948. I'll merge this into that PR, then finish that PR (it's all signed off, just blocked on this fix). If y'all want me to make a new version of the PR on master, I can do that.
Summary of the Pull Request
This is like a de-refactor of #1164. We're now building TerminalApp twice.
Once as a lib, and once as a dll. For whatever godforsaken reason, the wapproj
project type is a dumpster fire. If we try to build a static lib, then link
that into a DLL, the wapproj will absolutely not get all the resources,
dlls, xbfs, etc., that we need into the msix.
So now we're building TerminalApp twice. Once as a lib, which we'll use for
the unittests. Then we'll build it again, for consumption in WindowsTerminal.
All the combined files for these two projects are in
terminal-app-common.vcxproj, similar to host-common from the host project.
This does mean we'll have two pch.h steps for the same code. That's a giant
pain, but I think @miniksa is working on that.
References
PR Checklist