Use simpler csproj format #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait, you can use the core csproj for full framework projects? Why isn't this default? |
|
Because it doesn't work for all project types. Simple console style apps, though, work as expected. Others (like WebApps, WPF, etc), have issues at the moment (although the team is working to enable it for all). It is default, however, if you go through the ".NET Core -> Console App" menu and then change it to a whatever target framework (ie .NET 4.6) you want. |
|
Thanks! That makes sense. (I mean, except for the creating a netfx app via ".NET Core" 😉) Having looked at some of the msbuild .props and .targets now, I can see why it's taking time! |
|
Sure this looks way simpler for a little tool like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project is fairly simple right now, but the older style csproj format that it is using can cause issues as a project grows especially concerning merge conflicts. As long as required development on VS 2017 is okay, this new format is much cleaner and simpler than the older project files.