Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crank up static analysis audit #2607

Merged
merged 56 commits into from
Sep 10, 2019
Merged

Crank up static analysis audit #2607

merged 56 commits into from
Sep 10, 2019

Commits on Aug 29, 2019

  1. Make warnings errors for static analysis.

    @miniksa
    miniksa committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    1989eb9 View commit details
    Browse the repository at this point in the history

  2. C26446, Use .at instead of array indices

    @miniksa
    miniksa committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    65dec36 View commit details
    Browse the repository at this point in the history

  3. [Complex] C26446, Use .at instead of array indices - Reword UTF8OutPi… 

    …peReader to use std::array so we can use .at and move some pointers to iterators.
    @miniksa
    miniksa committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    23897b1 View commit details
    Browse the repository at this point in the history

  4. C26477, don't use 0 or NULL, use nullptr.

    @miniksa
    miniksa committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    bd2d5dd View commit details
    Browse the repository at this point in the history

  5. C26496, mark const if it's never written after creation

    @miniksa
    miniksa committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    b33a598 View commit details
    Browse the repository at this point in the history

  6. C26493, no C-style casts.

    @miniksa
    miniksa committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    c63289b View commit details
    Browse the repository at this point in the history

  7. C26435, choose one of virtual, override, or final

    @miniksa
    miniksa committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    a381f6a View commit details
    Browse the repository at this point in the history

  8. C26472, no static_cast for arithmetic conversions. narrow or narrow_cast

    @miniksa
    miniksa committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    8ea7401 View commit details
    Browse the repository at this point in the history

  9. C26433, overrides should be explicit.

    @miniksa
    miniksa committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    50e2d0c View commit details
    Browse the repository at this point in the history

  10. C26451, promote before arithmetic if storing in larger result size (o… 

    …r use safe math)
    @miniksa
    miniksa committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    8579d89 View commit details
    Browse the repository at this point in the history

  11. C26481, don't use pointer arithemetic. use span.

    @miniksa
    miniksa committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    8c3a629 View commit details
    Browse the repository at this point in the history

  12. C26447,C26440 - is noexcept but can throw or doesn't throw but not no… 

    …except
    @miniksa
    miniksa committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    4f1157c View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2019

  1. C26429, symbols not tested for nullness.

    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    30e8e7f View commit details
    Browse the repository at this point in the history

  2. C26474, don't use static_cast when an implicit cast is acceptable.

    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    cdfbf8f View commit details
    Browse the repository at this point in the history

  3. C26466, disable dynamic_cast rule because we're not RTTI due to OS po… 

    …licy. Also reinstitute C6001 and C6011 because they're not actually a part of the 'core checks' and they're goodness we had before I turned them off at the beginning of this series.
    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    230e7f4 View commit details
    Browse the repository at this point in the history

  4. C26485, refactor to avoid array-to-pointer decay.

    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    7d4096b View commit details
    Browse the repository at this point in the history

  5. C26473, do not cast pointer back to the same type.

    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    81ab580 View commit details
    Browse the repository at this point in the history

  6. C26494, uninitalized local variables

    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    d5d7cf4 View commit details
    Browse the repository at this point in the history

  7. C26462, const local variables that are unchanged.

    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    bbdfdf9 View commit details
    Browse the repository at this point in the history

  8. C26445, wstring_view byref may indicate a lifetime issue

    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    b180406 View commit details
    Browse the repository at this point in the history

  9. C26497, use constexpr for functions that could be evaluated at compil… 

    …e time.
    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    c956913 View commit details
    Browse the repository at this point in the history

  10. C26429, mark gsl::not_null on places where we don't test for null (sh… 

    …ouldn't need to, internal methods only.
    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    594dca9 View commit details
    Browse the repository at this point in the history

  11. C26430, not tested for nullness on all paths. I will just always chec… 

    …k for null as a defense against a bad QI implementation.
    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    45e5993 View commit details
    Browse the repository at this point in the history

  12. C26414, don't use smart pointers for locals

    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    9678dd8 View commit details
    Browse the repository at this point in the history

  13. C26460, use const on params that are unchanged (and remove some unnec… 

    …essary span refs).
    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    dd49c3e View commit details
    Browse the repository at this point in the history

  14. forgot all return paths to _FillRectangle.

    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    d8bc94f View commit details
    Browse the repository at this point in the history

  15. C26432, rule-of-five (if you define one of destruct/copy/move, then d… 

    …efine them all)
    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    2d3f285 View commit details
    Browse the repository at this point in the history

  16. C26443, overriding destructors shouldn't declare virtual nor override.

    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    3bbd8f4 View commit details
    Browse the repository at this point in the history

  17. C26434, do not hide base class methods. Overriding this one because i… 

    …t's going to require design changes that need a future todo.
    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    b78d917 View commit details
    Browse the repository at this point in the history

  18. C26426, global initializers calling non-constexpr. Suppress for defau… 

    …lt settings as changing to wstring_view cascades through the entire codebase (non-trivial, string_views aren't guaranteed as Z terminated.)
    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    b87f8f9 View commit details
    Browse the repository at this point in the history

  19. C26426, global initializer calls non-constexpr. This needs further co… 

    …nsideration. I brifely tried to turn GlyphWidth into a singleton class but it cascaded into interesting far corners of the code because IsGlyphFullWidth was liberally used everywhere for a long time. I'm punting here to a future work item.
    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    072bbfd View commit details
    Browse the repository at this point in the history

  20. C26426, global initializer calls non-constexpr. This is an easy move … 

    …to wstring_view.
    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    5d60d69 View commit details
    Browse the repository at this point in the history

  21. C26490, don't reinterpret_cast. It looks like the buffer can easily b… 

    …e char. Also use brace initialization per feedback.
    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    c7f0a34 View commit details
    Browse the repository at this point in the history

  22. C26436, destructor definition required for class with virtual methods.

    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    cd144e9 View commit details
    Browse the repository at this point in the history

  23. C26455, default constructor may not throw. Mark noexcept. (Trivial … 

    …cases.)
    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    e14a59a View commit details
    Browse the repository at this point in the history

  24. Define actual constructor for CodepointWidthDetector as default isn't… 

    … cutting it.
    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    87f5852 View commit details
    Browse the repository at this point in the history

  25. C26455, default constructor may not throw, mark as nothrow (another t… 

    …rivial one)
    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    b2c093f View commit details
    Browse the repository at this point in the history

  26. C26490, no reinterpret_cast. Suppress on OutputCellIterator because f… 

    …ixing it will make trouble in the Windows build if we're not careful thanks to non-differentiation of wchar_t and DWORD.
    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    3a0da64 View commit details
    Browse the repository at this point in the history

  27. C26490, no reinterpret_cast. Just use the actual struct and copy inst… 

    …ead of relying on the wink/nudge fact they're defined the same way.
    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    244fb72 View commit details
    Browse the repository at this point in the history

  28. C26440, default constructors should be noexcept.

    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    41f209f View commit details
    Browse the repository at this point in the history

  29. C26429, test for nullness or mark as not_null (and a few cascading wa… 

    …rnings.
    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    93aa945 View commit details
    Browse the repository at this point in the history

  30. C26497, you can mark this thing as constexpr.

    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    ae25a32 View commit details
    Browse the repository at this point in the history

  31. C26429, mark as not_null if not testing for nullness.

    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    01bd770 View commit details
    Browse the repository at this point in the history

  32. C26429, C26481, don't use pointer arithmetic, test for nullness. Also… 

    … eliminated completely unused GetTextRaw. Left todo behind for pointers as iterator boundaries in CharRowCellReference to fix later.
    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    23b4a46 View commit details
    Browse the repository at this point in the history

  33. C26481, don't use pointer arithmetic. Convert to measuring string wit… 

    …hin known limit and using view.
    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    4204733 View commit details
    Browse the repository at this point in the history

  34. Suppress last two errors (C26455 default constructor throw in DxEngin… 

    …e because it's due for refactoring soon anyway & C26444 custom construction/destruction on OutputCellIterator because I can't see what's going on and it needs more investigation and shouldn't hold this up). Also run codeformat.
    @miniksa
    miniksa committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    6735311 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2019

  1. constexprs have to go into the headers or other usages can't find the… 

    …m. Imagine that.
    @miniksa
    miniksa committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    7d9534b View commit details
    Browse the repository at this point in the history

  2. Fix redefinition of class name for constexpr method I moved from CPP … 

    …to HPP.
    @miniksa
    miniksa committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    7c66e66 View commit details
    Browse the repository at this point in the history

  3. fix merge conflict with master

    @miniksa
    miniksa committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    3bff2a3 View commit details
    Browse the repository at this point in the history

  4. code formatter, you're killing me.

    @miniksa
    miniksa committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    b7c1e05 View commit details
    Browse the repository at this point in the history

  5. fix remaining issues that appeared on merge.

    @miniksa
    miniksa committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    d0c207b View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2019

  1. Add GH issue IDs to all the suppress/disables that I left behind as t… 

    …hey were a bit too challenging to solve with this giant PR
    @miniksa
    miniksa committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    96cc772 View commit details
    Browse the repository at this point in the history

  2. PR feedback.

    @miniksa
    miniksa committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    689c21e View commit details
    Browse the repository at this point in the history

  3. use the array size for the read bounds. using extent on the newly-con… 

    …verted-to-array type doesn't give the correct value.
    @miniksa
    miniksa committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    fc81adf View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2019

  1. Some of the PR feedback.

    @miniksa
    miniksa committed Sep 6, 2019
    Configuration menu
    Copy the full SHA
    d8ff47a View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2019

  1. A few PR comments. A constexpr here, a misleading comment there, and … 

    …an extraneous local.
    @miniksa
    miniksa committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    18bacfe View commit details
    Browse the repository at this point in the history