Prevent "Options" propsheet from reverting cursor shape settings #2663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett-MSFT
approved these changes
Sep 5, 2019
ghost
requested review from
miniksa
approved these changes
Sep 5, 2019
carlos-zamora
approved these changes
Sep 7, 2019
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
DHowett-MSFT
removed
the
AutoMerge
|
Oh, one last thing. Would you check whether the new hidden radio button is in the tab stop order? It probably shouldn’t be if it is! |
|
@DHowett-MSFT Already checked, it isn't :) |
DHowett-MSFT
added
the
AutoMerge
DHowett-MSFT
pushed a commit
that referenced
this pull request
Sep 23, 2019
6 tasks
DHowett
pushed a commit
that referenced
this pull request
May 28, 2020
For a radio button group to work properly, they need sequential IDs. This moves the cursor radio buttons on the `conhost` property sheet to be sequential. ## References - Introduced with #2663 - Found while investigating #4186 ## PR Checklist * [x] Closes unfiled issue found while investigating #4186 * [x] I work here. * [x] Manual test. * [x] No documentation required. * [x] Am core contributor. ## Detailed Description of the Pull Request / Additional comments - `CheckRadioButton` takes a contiguous group of IDs. It will set one item in the list and then uncheck the rest. When a new one was added to the group, it was added to the end of the segment in the IDs file, but not immediately after the existing radio buttons. This means it accidentally turned off all the other buttons in the middle. - To resolve this, I moved all the cursor buttons into their own sequential group number and I deprecated the old values. ## Validation Steps Performed - [x] Ensured that the "Discard Old Duplicates" value was set in the registry, walked through debugger as `conhost` packed the `TRUE` value into the property sheet blob, walked through the property sheet `console.dll` as it unpacked the `TRUE`, then observed that the checkbox was actually set instead of getting unset by the `CheckRadioButton` call that went from 107 to 119 and accidentally unchecked number 112, `IDD_HISTORY_NODUP` even though I swear it was just set.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Whenever you'd open the "options" propsheet, we'd always revert the "cursor shape" to "legacy". This is obviously bad. This PR will make is so the cursor shape will persist, and only selecting a size manually will set the shape to "legacy".
PR Checklist
Detailed Description of the Pull Request / Additional comments
We actually need to add a hidden radio button to the "size" radio buttons on the options page, which acts as a placeholder for "non-legacy". Whenever we set the shape to not-legacy, we'll check that hidden radio button. Otherwise, whenever the Options page is activated, the selected radio button from each group gets a
BN_CLICKEDnotification, and if there's no button selected, the first will still get that notification.Validation Steps Performed
I've opened the propsheet and really mucked with it a bunch. This feels right now.