Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break if an early exit can not be found in InsertAttrRuns #3262

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Break if an early exit can not be found in InsertAttrRuns #3262

merged 1 commit into from
Nov 4, 2019

Conversation

skyline75489
Copy link
Collaborator

Summary of the Pull Request

A follow-up of #2937

References

#2937

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

zadjii-msft
zadjii-msft approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me...

@zadjii-msft zadjii-msft added Product-Conhost For issues in the Console codebase Area-Performance Performance-related issue labels Oct 25, 2019
@skyline75489 skyline75489 mentioned this pull request Nov 1, 2019
Closed
5 tasks
@skyline75489
Copy link
Collaborator Author

As the author of #2937 I feel eligible to say that, it is fine. Just a nice little patch that should've been included in #2937 .

@miniksa miniksa merged commit a4c24f8 into microsoft:master Nov 4, 2019
@skyline75489 skyline75489 deleted the fix/insertRunPerf-2 branch November 5, 2019 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniksa miniksa miniksa approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
Area-Performance Performance-related issue Product-Conhost For issues in the Console codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skyline75489 @miniksa @zadjii-msft