-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search - add search box control and implement search experience #3590
Search - add search box control and implement search experience #3590
Conversation
…n-Add-SearchBoxControl-and-Search-Experience
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only taken a cursory glance at a couple files so far, but I'm just gonna go ahead and pre-emptively block this PR until the spec (#3299) is merged
I am updating the spec today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fundamentally, this works so that's good. But there's definitely a few problems that need resolving before this can get merged. For me, the two remaining blocking issues are:
- the placeholder text color is wrong in dark mode
RenderData::GetTextBufferEndPosition
should not beGetCursorPosition
The other things I'm concerned about, but not blocking over:
- "Find..." needs to be localizable
Search
event should have a delegate with more args- Escape should be handled in the control too, as opposed to bubbling
- The whole
_goForward=!_goForward;_Search();_goForward=!_goForward
thing is weird
There are still some outstanding comments. |
Unblocking ones are moved to #3942 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm comfortable with this as long as we follow up on the followup issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning those blocking things up! We can fix the rest in post 😝
(I'm merging this since there's a hyper-quorum on it) |
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Thanks for merging ! I am working on the follow-ups these days. |
🎉 Handy links: |
Yeees! |
This is the PR for feature Search: #605
This PR includes the newly introduced SearchBoxControl in TermControl dir, which is the search bar for the search experience. And the codes that enable Search in Windows Terminal.
The PR that migrates the Conhost search module: #3279
Spec (still actively updating): #3299
PR Checklist
These functionalities are included in the search experience.
When the searchbox is open, the user could still interact with the terminal by clicking the terminal input area.
While I already have the search functionalities, currently there are still some known to-do works and I will keep updating my PR:
1) Theme adaptation. The search box background and font color
should change according to the theme,
2) Add background. Currently the elements in search box are all
transparent. However, we need a background.
3) Move button should be highlighted once clicked.
To test: