Add a 'splitPane' ShortcutAction #3722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ther vertically or horizontally
zadjii-msft
added
Area-Settings
zadjii-msft
requested review from
DHowett-MSFT,
miniksa,
carlos-zamora and
leonMSFT
DHowett-MSFT
approved these changes
Nov 26, 2019
carlos-zamora
approved these changes
Nov 27, 2019
| const std::string bindings0String{ R"([ | ||
| { "command": "splitVertical", "keys": ["ctrl+a"] }, | ||
| { "command": "splitHorizontal", "keys": ["ctrl+b"] }, | ||
| { "command": { "action": "splitPane", "split": null }, "keys": ["ctrl+c"] }, |
There was a problem hiding this comment.
Just curious, what does this do when you have split = null?
There was a problem hiding this comment.
Is this just for warnings?
There was a problem hiding this comment.
split=null will default to SplitState::None which actually does nothing. There's another issues laying around for validating that keybindings have args with actual reasonable values and warning if you don't
…ane-action # Conflicts: # src/cascadia/TerminalApp/AppKeyBindings.cpp # src/cascadia/TerminalApp/AppKeyBindings.h # src/cascadia/TerminalApp/AppKeyBindings.idl # src/cascadia/TerminalApp/TerminalPage.cpp
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
We already have "splitHorizontal" and "splitVertical", but those will both be deprecated in favor of "splitPane" with arguments.
Currently, there's one argument: "style", which is one of "vertical" or "horizontal."
References
This is being done in pursuit of supporting #607 and #998. I don't really want to lob #998 in with this one, since both that and this are hefty enough PRs even as they are. (I have a branch for #998, but it needs this first)
This will probably conflict with #3658
PR Checklist
Validation Steps Performed
Added new keybindings with the args - works
Tried the old keybindings without the args - still works