FindGuid helper function #3762
Merged
FindGuid helper function #3762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No feedback from the Azure pipeline
|
Does anyone know why the code formatting is failing? The Azure pipeline provides no feedback. |
|
Look at this for code format : https://github.com/microsoft/terminal/blob/master/doc/building.md |
zadjii-msft
requested changes
Nov 28, 2019
| } | ||
| } | ||
|
|
||
| return profileGuid; |
There was a problem hiding this comment.
I think my only real comment is that I think I'd prefer that we make this function return a std::optional<GUID>, and return std::nullopt when we didn't find a match instead of returning the null GUID, since the null GUID is technically a valid GUID.
ghost
added
Needs-Author-Feedback
DHowett-MSFT
approved these changes
Nov 30, 2019
zadjii-msft
approved these changes
Dec 2, 2019
|
Thanks for the contribution! |
zadjii-msft
added
Area-CodeHealth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Adds a simple helper function to look up the GUID associated with a profile name.
References
PR Checklist
SettingsTests!Detailed Description of the Pull Request / Additional comments
Very simple function, for-each through profiles checking for a match. Returns the associated GUID if found, else returns the null GUID.
This function is marked as
noexceptto comply with assumption made by otherCascadiaSettingsfunctions thatProfiles::GetGuiddoes not throw, despite it throwing.Validation Steps Performed
The new function is simple and can be visually validated, but added tests regardless. A new test group was added in
SettingsTestscalledTestHelperFunctionsto validate the new functionFindGuidand older functionFindProfile. This test group could be used to validate more helper functions inCascadiaSettingsas they're added. The new test group passes after runningte.exe TerminalApp.LocalTests.dll.