Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for "User Default" settings II #3892

Merged
7 commits merged into from
Dec 11, 2019
Merged

Add support for "User Default" settings II #3892

7 commits merged into from
Dec 11, 2019

Commits on Dec 6, 2019

  1. Well that was easy

    @zadjii-msft
    zadjii-msft committed Dec 6, 2019
    Configuration menu
    Copy the full SHA
    45c6af3 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2019

  1. Port the test over to the new syntax too

    @zadjii-msft
    zadjii-msft committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    2e87970 View commit details
    Browse the repository at this point in the history

  2. Update the docs too

    @zadjii-msft
    zadjii-msft committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    de6735b View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-Authored-By: Dustin L. Howett (MSFT) <duhowett@microsoft.com>
    @zadjii-msft @DHowett
    zadjii-msft and DHowett authored Dec 9, 2019
    Configuration menu
    Copy the full SHA
    a35d6ee View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/master' into dev/migrie/f/2325-o… 

    …bjectifying-settings

# Conflicts:
#	src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp
    @zadjii-msft
    zadjii-msft committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    6ea24e5 View commit details
    Browse the repository at this point in the history

  5. format these font names I suppose

    @zadjii-msft
    zadjii-msft committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    fa9c643 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'dev/migrie/f/2325-objectifying-settings' of https://git… 

    …hub.com/Microsoft/Terminal into dev/migrie/f/2325-objectifying-settings
    @zadjii-msft
    zadjii-msft committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    e0f242f View commit details
    Browse the repository at this point in the history