Add some issue numbers for TODOs from #3468 #3931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zadjii-msft
added
Area-TerminalControl
zadjii-msft
requested review from
carlos-zamora,
DHowett-MSFT,
miniksa and
leonMSFT
carlos-zamora
approved these changes
Dec 12, 2019
|
Suggestion: could you update SettingsSchema.md to have |
DHowett-MSFT
approved these changes
Dec 12, 2019
doc/cascadia/profiles.schema.json
Outdated
| @@ -509,6 +509,10 @@ | |||
| ], | |||
| "type": "string" | |||
| }, | |||
| "experimental.retroTerminalEffect": { | |||
| "description": "When set to true, enable retro terminal effects.", | |||
There was a problem hiding this comment.
"This is an experimental feature, and its continued existence is not guaranteed."
|
@msftbot merge this in 2 minutes |
ghost
added
the
AutoMerge
|
Hello @zadjii-msft! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
The original PR had a few TODOs in it without issue numbers. IMO, this wasn't important enough to block the PR over. Also I'm impatient and wanted that setting.
After I merged the PR I created the issues and added the numbers myself.
References
PR Checklist