Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply audit mode to TerminalInput/Adapter/Parser libraries #4005

Merged
28 commits merged into from
Jan 3, 2020

Commits on Dec 12, 2019

  1. Adjust the public methods to the state machine to use more modern con…

    …structs, propagate changes out.
    miniksa committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    7461678 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2019

  1. State Machine, Output State Machine Engine, and Tracing classes use r…

    …eferences, string views, standard types.
    miniksa committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    169bfb3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    64d1496 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2019

  1. Dropping hungarians, using unique_ptr constructors, BOOL to bool, usi…

    …ng string views everywhere, size_ts over smaller sizes in prep for massive buffers, and so on and so on.
    miniksa committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    fee4b54 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dcf0e8f View commit details
    Browse the repository at this point in the history
  3. Remove many but probably not all of the std::wstring intermediates be…

    …ing used for calling ProcessString on the parser in the tests.
    miniksa committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    d97a4da View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2019

  1. found the other one.

    miniksa committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    68bc729 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e73d516 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3a92383 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a2c234a View commit details
    Browse the repository at this point in the history
  5. code formatting run.

    miniksa committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    576da99 View commit details
    Browse the repository at this point in the history
  6. TerminalParser is now audit clean. Noexcepts propagated. Removed C-ca…

    …sts. Fixed some rule of 5s, suppressed others. Suppressed constexpr suggestions. Use narrow_cast where applicable. Consts on unchanged variables. .at() for array accesses, and so on.
    miniksa committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    1616801 View commit details
    Browse the repository at this point in the history
  7. TerminalInput is now audited too. Most of it was moving the tables to…

    … constexpr and gluing everything back together. Otherwise, the usual suspects of array-to-pointer decay and noexcepts and whatnot.
    miniksa committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    e769ad3 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    608e10c View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2019

  1. Configuration menu
    Copy the full SHA
    f78f328 View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2019

  1. Configuration menu
    Copy the full SHA
    cfca853 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2020

  1. Add TIL library for header-based utilities we need to manage audit mo…

    …de (and in the future do conversions and whatnot safelyish). Use it to bypass the warnings in a methodic way for where we already know the bounds FOR SURE. Also, try to adjust some of adapt dispatch's arithmetic to make it not substantially worse and still pass audit before we get to improving our safemath library.
    miniksa committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    9d8da4f View commit details
    Browse the repository at this point in the history
  2. Comments from Dustin about references, function level try blocks, and…

    … a few other odds and ends.
    miniksa committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    fc49c35 View commit details
    Browse the repository at this point in the history
  3. Drop constexpr suppressions and just make them static constexprs in e…

    …ach file. Run code format.
    miniksa committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    fc05775 View commit details
    Browse the repository at this point in the history
  4. Revert adaptDispatch.cpp

    miniksa authored Jan 2, 2020
    1 Configuration menu
    Copy the full SHA
    d28c8c1 View commit details
    Browse the repository at this point in the history
  5. Restore overzealous revert.

    miniksa committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    8853d1a View commit details
    Browse the repository at this point in the history
  6. Correct SA failures but still using safemath. Ensure unit tests still…

    … pass. We can adjust the behavior re: clamping later.
    miniksa committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    796aea3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5cc2943 View commit details
    Browse the repository at this point in the history
  8. fix the code format

    miniksa committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    fdd4dcc View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    8a82b2c View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    a009ef1 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    916a9de View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    e4115ee View commit details
    Browse the repository at this point in the history