Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: include FAR in ThirdPartyToolProfiles.md #4242

Merged
merged 3 commits into from
Jan 15, 2020
Merged

doc: include FAR in ThirdPartyToolProfiles.md #4242

merged 3 commits into from
Jan 15, 2020

Conversation

vtabota
Copy link
Contributor

@vtabota vtabota commented Jan 15, 2020

Summary of the Pull Request

New 3rd part tool "Far Manager" configuration.

References

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

miniksa
miniksa reviewed Jan 15, 2020
View reviewed changes
doc/user-docs/ThirdPartyToolProfiles.md Outdated
```json
{
"name" : "Far",
"commandline" : "cmd.exe /c \"c:\\program files\\far manager\\far.exe\"",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't just launch straight into far.exe?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, wut

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, yes it can.

@DHowett-MSFT DHowett-MSFT changed the title Update ThirdPartyToolProfiles.md doc: include FAR in ThirdPartyToolProfiles.md Jan 15, 2020
@DHowett-MSFT DHowett-MSFT merged commit 6d6fb7f into microsoft:master Jan 15, 2020
@DHowett-MSFT
Copy link
Contributor

Thanks!

@vtabota vtabota deleted the patch-1 branch January 16, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett-MSFT DHowett-MSFT DHowett-MSFT approved these changes

@miniksa miniksa miniksa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vtabota @DHowett-MSFT @miniksa