-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schema: add support for "auto" split value #4249
schema: add support for "auto" split value #4249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be all for auto
being the default value :)
doc/cascadia/profiles.schema.json
Outdated
@@ -215,7 +216,7 @@ | |||
"split": { | |||
"$ref": "#/definitions/SplitState", | |||
"default": "vertical", | |||
"description": "The orientation to split the pane in, either vertical (think [|]) or horizontal (think [-])" | |||
"description": "The orientation to split the pane in, either vertical (think [|]), horizontal (think [-]), or auto" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you describe auto in the description too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing
Related to #4025 |
Added the requested changes |
Thanks for updating this! This is totally on me for not doing that in the first place 😝 |
No problem! 💯 |
Summary of the Pull Request
profiles.schema.json
did not haveauto
as a valid value for thesplit
attribute. This PR adds the support and makes a minor update to the details associated with thesplit
attribute.References
PR Checklist
Detailed Description of the Pull Request / Additional comments
Potentially the
default
value forSplitPaneAction
should be set toauto
as well. Let me know your thoughts.Validation Steps Performed
Changed the
$schema
attribute in my localprofiles.json
to the updatedprofiles.schema.json
and ensured thatauto
did not have a squiggly line like in #4245.