-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "wether" from dictionary, add "VTE" #5207
Conversation
Hold up, I’m not sure we should be changing the dictionary itself. I think it’s supposed to be representative of English. /cc @jsoref to keep me honest |
In general, you shouldn't be adding to As for removing items, if you want to use a subset of the dictionary because it's too likely that people will use a word that, while technically an English word, is not actually the one people should be using, then, yes, removing it from |
As for why the check didn't block things, that's a bit of a mess: j4james/terminal#clamp-vt-parameters got a fail from the bot when j4james@d2690a0 was pushed to @j4james 's repository which triggered d2690a0/comment which is j4james@d2690a0#commitcomment-38185159 which GitHub also renders as #5200 (comment) . I've fixed the schedule code so that there's a way to ensure comments exist (unfortunately, that check wouldn't appear as an ❌ against the PR, because it runs in response to a different event). I'm planning to write code so that the bot will "resolve" older comments when it runs again. -- I've started thinking about this code. I could probably have it add/remove a "review" thing for "changes requested". -- I haven't looked into this yet. I don't think I'll be able to implement the unwritten bits before mid-April, but |
Hello @zadjii-msft! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 6 hours 59 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
FYI, I definitely got a notification of the VTE spelling issue. I just didn't know how to go about whitelisting it, and I had intended to follow up on that, but the PR got merged a bit faster than I had expected. |
Sorry about that 😄 |
@j4james no worries, I thought it had been resolved since the PR wasn't blocked, but it's nbd. We've merged much worse problems into master before 😅 |
Technically, "wether" is a word but I'd be shocked if there's a scenario for us to use it properly in this repo, so I'm pulling it from the dictionary.
Also, in #5200, we added "VTE", which is totally a valid acronym, to the codebase, but not the whitelist. I'm not sure why the bot let me merge it anyways, but I'm fixing it now.