-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various Differential Drawing fixes for #5345 #5427
Conversation
This is just here to help me debug
…might be able to do it without reverting the double resize
I was wondering if the DIP calculation should have gone the other way in term control: transform the cursor position into raw pixels (dpx) instead of the font size into dips. @miniksa mentioned something about rounding issues, if I remember, and being able to map the cursor position literally into the actual pixels it hit might be safer? IDK. It makes the math clearer at the points at which the cursor position is used because we can have one helper (cursor position to physical) instead of having to apply the font size scale? |
For the record the WPF control is in DPX. We eventually will converge the logic as much as possible between the two (there’s no reason for us to have multiple implementations of selection, which requires position math, for example) but that’s post 1.0 stuff |
I mentally thought of it the other way with moving everything from DPI to DPX and doing it in DPX. But I'm willing to take whatever works at this point and clean it up in post. This process has revealed a bit of a rough edge with |
(cherry picked from commit ba1a8a34292180cae10c135743ecd94b1da6f286)
(cherry picked from commit 98cdbeca349acb55c5b5aef1d96206a8fa7b62e4)
@miniksa I think this should have resolutions for the little things people brought up by now. |
@zadjii-msft, OK Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good enough. I can finalize any cleanup in the other PR. Thank you @zadjii-msft.
Summary of the Pull Request
This is everything I've found in my attempt to resurrect #5345.
There are a bunch of new bugs and edge cases I've added to #5345 (comment). Largely, things are much better.
TermControl.cpp
til
to make our lives easier.TSFInputControl.cpp
til
in this method to make our life easierScreenInfo.cpp
point.h
point(float, float)
ctor.rectangle.h
Rect
cast.size.h
size(int, ptrdiff_t)
ctor.size(ptrdiff_t, int)
ctor.size(float, float)
ctor.DxRenderer.cpp
_firstFrame
, and don't bother withPresent1
. We know it won't work. So don't._invalidMap.all()
inPaintBackground
, because it mostly won't work.