dx: when filling an HWND target, use the actual background color #5848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no guarantee that the HWND's backing color matches our expected backing color.
|
@miniksa I know you strove to reduce or remove the differences between the hwnd and composition renderers. An alternative would be to localize a change to the WPF terminal control that sets its window's background to the right color, but... AFAIK background color is per-class, not per-window. |
zadjii-msft
approved these changes
May 11, 2020
Eh, no big deal. It's fine. |
miniksa
approved these changes
May 11, 2020
ZoeyR
approved these changes
May 11, 2020
DHowett-MSFT
changed the title
DHowett-MSFT
pushed a commit
that referenced
this pull request
May 11, 2020
There is no guarantee that the HWND's backing color matches our expected backing color. This repairs the gutter in the WPF terminal. (cherry picked from commit 177fd74)
DHowett-MSFT
pushed a commit
that referenced
this pull request
May 11, 2020
There is no guarantee that the HWND's backing color matches our expected backing color. This repairs the gutter in the WPF terminal. (cherry picked from commit 177fd74)
jelster
pushed a commit
to jelster/terminal
that referenced
this pull request
May 28, 2020
…rosoft#5848) There is no guarantee that the HWND's backing color matches our expected backing color. This repairs the gutter in the WPF terminal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no guarantee that the HWND's backing color matches our expected
backing color.
This repairs the gutter in the WPF terminal.