Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial support for VT DCS sequences #6328

Merged
merged 19 commits into from
Aug 17, 2020
Merged

Add initial support for VT DCS sequences #6328

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
4cf85bb
Init DCS support
skyline75489 Jun 3, 2020
a0a98b2
More DCS support
skyline75489 Jun 3, 2020
6bc3198
Spelling
skyline75489 Jun 3, 2020
5261fe2
Merge branch 'master' into feature/init-dcs-support
skyline75489 Jul 20, 2020
d76eedd
Various fix & test cases
skyline75489 Jul 20, 2020
1b7fdf9
More tests
skyline75489 Jul 20, 2020
1c8d197
Format
skyline75489 Jul 20, 2020
3d428fa
CI failure
skyline75489 Jul 20, 2020
eeb07b7
Merge remote
skyline75489 Jul 22, 2020
f083f62
j4james rocks!
skyline75489 Jul 22, 2020
16d16fd
Resolve comments
skyline75489 Jul 23, 2020
ba70dd9
Style
skyline75489 Jul 24, 2020
517e830
Fix style
skyline75489 Jul 24, 2020
e363483
Resolve comments
skyline75489 Jul 25, 2020
9904660
Merge branch 'feature/init-dcs-support' of https://github.com/skyline…
skyline75489 Jul 27, 2020
df94fb0
Comments
skyline75489 Jul 29, 2020
9873040
Merge branch 'master' into feature/init-dcs-support
skyline75489 Aug 17, 2020
a4746a6
Resolve comments
skyline75489 Aug 17, 2020
f42a486
Apply suggestions from code review
DHowett Aug 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/actions/spell-check/dictionary/dictionary.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99401,6 +99401,8 @@ DCP
DCPR
DCPSK
DCS
Dcs
dcs
DCT
DCTN
DCTS
Expand Down
1 change: 1 addition & 0 deletions src/terminal/parser/ascii.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,6 @@ namespace Microsoft::Console::VirtualTerminal
US = 0x1F, // Unit Separator
SPC = 0x20, // Space, first printable character
DEL = 0x7F, // Delete
ST = 0x9c, // String terminator
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Why was this added to the AsciiChars enum? It's not technically ASCII is it? And neither CSI or DCS are defined here. It just seems a bit unnecessary.

Copy link
Collaborator Author

@skyline75489 skyline75489 Jul 22, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm..I added it here without be aware that it's not ASCII. That being said, should we have a place where CSI, DCS and ST is enum?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel strongly about it either way. If the only place those characters are currently used are in methods like _isDcsIndicator and _isStringTerminator then they're kind of self-documenting anyway.

};
}
Loading