-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial support for VT DCS sequences #6328
Merged
DHowett
merged 19 commits into
microsoft:master
from
skyline75489:feature/init-dcs-support
Aug 17, 2020
Merged
Changes from 16 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
4cf85bb
Init DCS support
skyline75489 a0a98b2
More DCS support
skyline75489 6bc3198
Spelling
skyline75489 5261fe2
Merge branch 'master' into feature/init-dcs-support
skyline75489 d76eedd
Various fix & test cases
skyline75489 1b7fdf9
More tests
skyline75489 1c8d197
Format
skyline75489 3d428fa
CI failure
skyline75489 eeb07b7
Merge remote
skyline75489 f083f62
j4james rocks!
skyline75489 16d16fd
Resolve comments
skyline75489 ba70dd9
Style
skyline75489 517e830
Fix style
skyline75489 e363483
Resolve comments
skyline75489 9904660
Merge branch 'feature/init-dcs-support' of https://github.com/skyline…
skyline75489 df94fb0
Comments
skyline75489 9873040
Merge branch 'master' into feature/init-dcs-support
skyline75489 a4746a6
Resolve comments
skyline75489 f42a486
Apply suggestions from code review
DHowett File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -99401,6 +99401,8 @@ DCP | |
DCPR | ||
DCPSK | ||
DCS | ||
Dcs | ||
dcs | ||
DCT | ||
DCTN | ||
DCTS | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realised now that this should also be checking that intermediates is empty, otherwise it'll be matching sequences with an intermediate - like
ESC sp \
- which it really shouldn't be. It's not that big a deal, and I'll probably end up moving this into the main switch with an actual action code once PR #7304 is merged, but it wouldn't harm to add an intermediate check here in the mean time.