Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for "Always on top" mode #6903

Merged
15 commits merged into from
Jul 14, 2020
Merged

Add support for "Always on top" mode #6903

15 commits merged into from
Jul 14, 2020

Commits on Jun 26, 2020

  1. Proof of concept, borderless for the NCIW. Need to do IW, and borderl… 

    …ess<->Fullscreen still
    @zadjii-msft
    zadjii-msft committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    d5fe651 View commit details
    Browse the repository at this point in the history

  2. Now it works for the IW as well

    @zadjii-msft
    zadjii-msft committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    e6c8b65 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2020

  1. This feels good for all the IW scenarios - toggling both FS and borde… 

    …rless in either mode. Now double check NCIW...
    @zadjii-msft
    zadjii-msft committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    95f4904 View commit details
    Browse the repository at this point in the history

  2. NCIW works _pretty_ well, but loses the top border on resize. This is… 

    … an acceptable known issue, since the alternative is having a white line on top of the window when it loses focus
    @zadjii-msft
    zadjii-msft committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    6356aaf View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into dev/migrie/f/2238-i… 

    …ll-just-do-it-myself

# Conflicts:
#	src/cascadia/TerminalApp/ActionAndArgs.cpp
#	src/cascadia/TerminalApp/AppActionHandlers.cpp
#	src/cascadia/TerminalApp/ShortcutActionDispatch.cpp
#	src/cascadia/TerminalApp/ShortcutActionDispatch.h
#	src/cascadia/TerminalApp/ShortcutActionDispatch.idl
#	src/cascadia/TerminalApp/TerminalPage.cpp
#	src/cascadia/TerminalApp/TerminalPage.h
    @zadjii-msft
    zadjii-msft committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    52084d5 View commit details
    Browse the repository at this point in the history

  4. cleanup for review

    @zadjii-msft
    zadjii-msft committed Jul 6, 2020
    1 Configuration menu
    Copy the full SHA
    fcb2d48 View commit details
    Browse the repository at this point in the history

  5. add to defaults.json too, so it'll be picked up as a command automati… 

    …cally
    @zadjii-msft
    zadjii-msft committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    a50d2e9 View commit details
    Browse the repository at this point in the history

  6. add to schema

    @zadjii-msft
    zadjii-msft committed Jul 6, 2020
    1 Configuration menu
    Copy the full SHA
    f5a1a68 View commit details
    Browse the repository at this point in the history

  7. good bot

    @zadjii-msft
    zadjii-msft committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    06506f2 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2020

  1. accidentally the whole thing

    @zadjii-msft
    zadjii-msft committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    a6b7f03 View commit details
    Browse the repository at this point in the history

  2. cleanup code for review

    @zadjii-msft
    zadjii-msft committed Jul 7, 2020
    1 Configuration menu
    Copy the full SHA
    8fb257a View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2020

  1. Merge remote-tracking branch 'origin/master' into dev/migrie/f/3038-a… 

    …lwaysOnTop

# Conflicts:
#	doc/cascadia/profiles.schema.json
#	src/cascadia/TerminalApp/ActionAndArgs.cpp
#	src/cascadia/TerminalApp/AppActionHandlers.cpp
#	src/cascadia/TerminalApp/AppLogic.h
#	src/cascadia/TerminalApp/AppLogic.idl
#	src/cascadia/TerminalApp/Resources/en-US/Resources.resw
#	src/cascadia/TerminalApp/ShortcutActionDispatch.cpp
#	src/cascadia/TerminalApp/ShortcutActionDispatch.h
#	src/cascadia/TerminalApp/ShortcutActionDispatch.idl
#	src/cascadia/TerminalApp/TerminalPage.cpp
#	src/cascadia/TerminalApp/TerminalPage.h
#	src/cascadia/TerminalApp/TerminalPage.idl
#	src/cascadia/TerminalApp/defaults.json
#	src/cascadia/WindowsTerminal/AppHost.cpp
#	src/cascadia/WindowsTerminal/AppHost.h
#	src/cascadia/WindowsTerminal/IslandWindow.cpp
#	src/cascadia/WindowsTerminal/IslandWindow.h
#	src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp
    @zadjii-msft
    zadjii-msft committed Jul 13, 2020
    1 Configuration menu
    Copy the full SHA
    2937fcb View commit details
    Browse the repository at this point in the history

  2. this was missed in the merge

    @zadjii-msft
    zadjii-msft committed Jul 13, 2020
    1 Configuration menu
    Copy the full SHA
    cdc80a7 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2020

  1. feedback from PR

    @zadjii-msft
    zadjii-msft committed Jul 14, 2020
    1 Configuration menu
    Copy the full SHA
    35f1950 View commit details
    Browse the repository at this point in the history

  2. good bot

    @zadjii-msft
    zadjii-msft committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    46e478b View commit details
    Browse the repository at this point in the history