Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add startOnUserLogin & fullscreen launchMode to schema #7300

Merged
merged 3 commits into from
Aug 18, 2020
Merged

Add startOnUserLogin & fullscreen launchMode to schema #7300

merged 3 commits into from
Aug 18, 2020

Conversation

jcabot21
Copy link
Contributor

Summary of the Pull Request

Adds missing elements to JSON schema.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Only updates the JSON schema with missing elements

@ghost ghost added Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Product-Terminal The new Windows Terminal. labels Aug 14, 2020
DHowett
DHowett approved these changes Aug 15, 2020
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Thanks for doing this.

@DHowett DHowett changed the title Fix #7294 Some settings are missing from JSON schema Add startOnUserLogin & fullscreen launchMode to schema Aug 18, 2020
@DHowett DHowett merged commit 8943f68 into microsoft:master Aug 18, 2020
DHowett pushed a commit that referenced this pull request Aug 18, 2020
@jcabot21 @DHowett
Add startOnUserLogin & fullscreen launchMode to schema (#7300)
b58f601 
Fixes #7294

Co-authored-by: Mike Griese <migrie@microsoft.com>
(cherry picked from commit 8943f68)
DHowett pushed a commit that referenced this pull request Aug 18, 2020
@jcabot21 @DHowett
Add startOnUserLogin & fullscreen launchMode to schema (#7300)
f1878f7 
Fixes #7294

Co-authored-by: Mike Griese <migrie@microsoft.com>
(cherry picked from commit 8943f68)
MichelleTanPY pushed a commit to MichelleTanPY/terminal that referenced this pull request Aug 18, 2020
@jcabot21 @zadjii-msft @MichelleTanPY
Add startOnUserLogin & fullscreen launchMode to schema (microsoft#7300)
c9c7c9e 
Fixes microsoft#7294

Co-authored-by: Mike Griese <migrie@microsoft.com>
@jcabot21 jcabot21 deleted the fix-json-schema branch April 26, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@agniutkarsh agniutkarsh agniutkarsh approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some settings are missing from JSON schema
4 participants
@jcabot21 @DHowett @zadjii-msft @agniutkarsh