Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Settings UI Prototype #7370

Merged
106 commits merged into from
Sep 17, 2020
Merged

Add a Settings UI Prototype #7370

106 commits merged into from
Sep 17, 2020

Conversation

carlos-zamora
Copy link
Member

@carlos-zamora carlos-zamora commented Aug 22, 2020

This commit introduces a rough prototype of the Settings UI as the
TerminalSettingsEditor. This project was added to OpenConsole.sln and
deploys as a standalone app. Some databinding is configured to a fake
TerminalSettingsModel (located in the ObjectModel folder).

This commit will start the settings UI feature branch, which will
receive a full review on merge-back into main.

References #6720 - Settings UI Spec and Design
References #1564 - Settings UI Feature/Epic

@carlos-zamora
Copy link
Member Author

Could I get a bit of guidance for how to handle these misspellings? Most seem to be function names.

@zadjii-msft
Copy link
Member

without looking at any code of course

  • addnew - looks like a real typo
  • bright* - I'd make these camelCase if possible, that'll fix the bot
  • delimeters - looks like a real typo
  • globalprofile - can you camelCase this?
  • homegriditem - can you camelCase this?
  • muxc - microsoft.txt
  • snprintf - apis.txt
  • Subheader - can you camelCase this?
  • Subpage - can you camelCase this?
  • tolower - apis.txt
  • viceversa - "vice-versa"
  • wcsstr - apis.txt

@quangkieu quangkieu mentioned this pull request Aug 27, 2020
6 tasks
@DHowett DHowett changed the base branch from master to feature/settings-ui August 28, 2020 00:30
@DHowett
Copy link
Member

DHowett commented Aug 28, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rationale

This is merging into a feature branch that Leon and Carlos are going to be hammering on for a while. It is a prototype, yes, but it is getting refined.

There will be a final review when the feature branch merges.

src/cascadia/TerminalSettingsEditor/AddProfile.xaml Outdated Show resolved Hide resolved
src/cascadia/TerminalSettingsEditor/App.cpp Show resolved Hide resolved
src/cascadia/TerminalSettingsEditor/App.h Show resolved Hide resolved
src/cascadia/TerminalSettingsEditor/App.idl Show resolved Hide resolved
src/cascadia/TerminalSettingsEditor/App.xaml Show resolved Hide resolved
src/cascadia/TerminalSettingsEditor/Utils.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@leonMSFT leonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I think a lot of the things I saw are stuff that's going to be deleted and polished naturally as we work towards endgame. i.e. large amounts of repeating XAML elements just becomes a templated item + data binding.

Blocking for now just so we can sprinkle TODOs throughout the code first before merging this in.

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Sep 11, 2020
Copy link
Contributor

@leonMSFT leonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the Leon callouts - those changes are currently already in the branch that I'm currently working on to put the settings UI in a tab, so they'll come in a later PR.

I've also put the Epic callouts in a follow up list in #1564. I expect we'll be referring back to that list often as we work thoroughly in the code.

@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Sep 14, 2020
@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Sep 17, 2020
@ghost
Copy link

ghost commented Sep 17, 2020

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 9493ca0 into feature/settings-ui Sep 17, 2020
@ghost ghost deleted the dev/cazamor/settings-ui branch September 17, 2020 18:33
leonMSFT pushed a commit that referenced this pull request Sep 24, 2020
This commit introduces a rough prototype of the Settings UI as the
`TerminalSettingsEditor`. This project was added to OpenConsole.sln and
deploys as a standalone app. Some databinding is configured to a fake
TerminalSettingsModel (located in the ObjectModel folder).

This commit will start the settings UI feature branch, which will
receive a full review on merge-back into main.

References #6720 - Settings UI Spec and Design
References #1564 - Settings UI Feature/Epic
@carlos-zamora carlos-zamora mentioned this pull request Dec 11, 2020
25 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.