Hook up the WIL fallback error tracer in Terminal #7864
Conversation
|
/azp run |
|
No pipelines are associated with this pull request. |
|
Question: One thing I've never really understood about WIL is this: What's the difference between "telemetry" and "non-telemetry" messages written by the _IF_FAILED error handling macros? I know that in the Microsoft-internal extension to WIL, only the telemetry messages get written out on the DLL's previously registered TraceLogging ETW path, which this PR emulates, but I don't know how WIL decides on the telemetry versus not distinction in the first place. |
|
That's an excellent question. I believe it's telemetry by default unless you use a member on the WIL helper class (the one that the macros emit, and which is elided here!) to set the default reporting type to |
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
This pull request introduces (a very, very stripped-down copy of) the WIL fallback error reporter. It emits error records, usually immediately before the application implodes, into the event stream. This should improve diagnosability of issues that take Terminal down, and allow us to give out a .wprp file to gather traces from users.
This pull request introduces (a very, very stripped-down copy of) the WIL fallback error reporter. It emits error records, usually immediately before the application implodes, into the event stream. This should improve diagnosability of issues that take Terminal down, and allow us to give out a .wprp file to gather traces from users. (cherry picked from commit cd76893)
|
🎉 Handy links: |
|
🎉 Handy links: |
This pull request introduces (a very, very stripped-down copy of) the
WIL fallback error reporter.
It emits error records, usually immediately before the application
implodes, into the event stream.
This should improve diagnosability of issues that take Terminal down,
and allow us to give out a .wprp file to gather traces from users.