Prevent resizing terminal to a lower-than-minimum width #8066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-User Interface
Don-Vito
changed the title
|
@DHowett - no more hacktoberfest labeling is needed - the tree is already planted. We did it 🌳 |
|
@zadjii-msft - resolved conflicts and bumping 😊 |
zadjii-msft
reviewed
Nov 10, 2020
zadjii-msft
approved these changes
Nov 10, 2020
DHowett
reviewed
Nov 11, 2020
| @@ -2,6 +2,7 @@ | |||
| // Licensed under the MIT license. | |||
|
|
|||
| #include "pch.h" | |||
| #include <WinUser.h> | |||
There was a problem hiding this comment.
this might belong in the pch.h in this project with the other platform includes. I'm very surprised it isn't already included!
Comment on lines
286
to
287
| // that might occur in the scenarios, where _OnSizing is bypassed. | ||
| // An example of such scenario, is anchoring the window to the top/bottom screen border |
There was a problem hiding this comment.
Suggested change
| // that might occur in the scenarios, where _OnSizing is bypassed. | |
| // An example of such scenario, is anchoring the window to the top/bottom screen border | |
| // that might occur in the scenarios where _OnSizing is bypassed. | |
| // An example of such scenario is anchoring the window to the top/bottom screen border |
extraneous commas
There was a problem hiding this comment.
I will never learn this - in my mother tongue the comma is required.. while in English it is not.
| const auto nonClientSizeScaled = GetTotalNonClientExclusiveSize(dpix); | ||
| const auto scale = base::ClampedNumeric<float>(dpix) / USER_DEFAULT_SCREEN_DPI; | ||
|
|
||
| LPMINMAXINFO lpMinMaxInfo = reinterpret_cast<LPMINMAXINFO>(lParam); |
There was a problem hiding this comment.
Suggested change
| LPMINMAXINFO lpMinMaxInfo = reinterpret_cast<LPMINMAXINFO>(lParam); | |
| auto lpMinMaxInfo = reinterpret_cast<LPMINMAXINFO>(lParam); |
(repetitive w/ the cast type)
DHowett
changed the title
DHowett
changed the title
DHowett
changed the title
atherkhan
approved these changes
Nov 11, 2020
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
DHowett
pushed a commit
that referenced
this pull request
Jan 25, 2021
Until now, we relied on WM_SIZING to ensure that the island is not downsized below minimal allowed dimensions. However, on some occasions WM_WINDOWPOSCHANGED, e.g. when anchoring a window to the top/bottom of the screen. This message will use dimensions obtained from WM_GETMINMAXINFO. Until now we didn't override this value, falling back to the defaults. As a result we got an inconsistent behavior (at least when attaching the anchor). I added logic very similar to the one we use in IslandWindow::_OnSizing to the MINMAXINFO handler: snap the client area, add non client exclusive are, consider DPI along the computation. * Manual testing of minimizing, maximizing, resizing, attaching different anchors, etc. Closes #8026 (cherry picked from commit e3fcfcc)
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, we relied on WM_SIZING to ensure that the island is not
downsized below minimal allowed dimensions. However, on some occasions
WM_WINDOWPOSCHANGED, e.g. when anchoring a window to the top/bottom of
the screen. This message will use dimensions obtained from
WM_GETMINMAXINFO. Until now we didn't override this value, falling back
to the defaults. As a result we got an inconsistent behavior (at least
when attaching the anchor).
I added logic very similar to the one we use in IslandWindow::_OnSizing
to the MINMAXINFO handler: snap the client area, add non client
exclusive are, consider DPI along the computation.
Validation Steps Performed
different anchors, etc.
Closes #8026