Make CloseWarningDialog async #8117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As opening the dialog is async, the flag can be reset in the same method. This way the flag operations occur in the same method. Also, the event handler for cancel becomes obsolete.
zadjii-msft
approved these changes
Nov 20, 2020
zadjii-msft
added
Area-User Interface
ghost
requested review from
miniksa,
carlos-zamora,
DHowett,
leonMSFT and
PankajBhojwani
DHowett
reviewed
Nov 20, 2020
DHowett
approved these changes
Nov 20, 2020
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mpela81
pushed a commit
to mpela81/terminal
that referenced
this pull request
Nov 22, 2020
The CloseWarningDialog is now "awaitable"/async, as suggested in PR microsoft#7871. As opening the dialog is async, the flag can be reset in the same method. This way the flag operations occur in the same method. The event handlers of the buttons became obsolete and are removed. ## Validation Steps Performed Tested manually.
|
Glad I could help. 😊 |
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CloseWarningDialog is now "awaitable"/async, as suggested in PR #7871.
As opening the dialog is async, the flag can be reset in the same
method. This way the flag operations occur in the same method. The
event handlers of the buttons became obsolete and are removed.
Validation Steps Performed
Tested manually.