Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teach the command palette to clamp its indices on page up/down #8190

Merged

Conversation

Don-Vito
Copy link
Contributor

@Don-Vito Don-Vito commented Nov 7, 2020

This commit will teach CommandPalette to clamp the scroll page up and
scroll page down navigation so as to not wrap.

Closes #8189

@ghost ghost added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Nov 7, 2020
@Don-Vito Don-Vito marked this pull request as draft November 7, 2020 21:28
@Don-Vito Don-Vito marked this pull request as ready for review November 7, 2020 21:34
@github-actions
Copy link

github-actions bot commented Nov 7, 2020

New misspellings found, please review:

  • Toindex
To accept these changes, run the following commands
perl -e '
my @expect_files=qw('".github/actions/spell-check/expect/5757ec679b03a4240130c3c53766c91bbc5cd6a7.txt
.github/actions/spell-check/expect/655f007265b351e140d20b3976792523ad689241.txt
.github/actions/spell-check/expect/alphabet.txt
.github/actions/spell-check/expect/expect.txt
.github/actions/spell-check/expect/web.txt"');
@ARGV=@expect_files;
my @stale=qw('"AAAAA Bopomofo CParams GENERATEPROJECTPRIFILE hhhh Inlines renamer rgus SGRXY Unfocus xe xlang "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^($re)(?:$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spell-check/expect/d5f7e3a50a81cd5aacedfcc629b003e09e04b8f9.txt";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"inlines Renamer Toindex unfocus "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
git add .github/actions/spell-check/expect || echo '... you want to ensure .github/actions/spell-check/expect/d5f7e3a50a81cd5aacedfcc629b003e09e04b8f9.txt is added to your repository...'
✏️ Contributor please read this

By default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.

⚠️ The command is written for posix shells. You can copy the contents of each perl command excluding the outer ' marks and dropping any '"/"' quotation mark pairs into a file and then run perl file.pl from the root of the repository to run the code. Alternatively, you can manually insert the items...

If the listed items are:

  • ... misspelled, then please correct them instead of using the command.
  • ... names, please add them to .github/actions/spell-check/dictionary/names.txt.
  • ... APIs, you can add them to a file in .github/actions/spell-check/dictionary/.
  • ... just things you're using, please add them to an appropriate file in .github/actions/spell-check/expect/.
  • ... tokens you only need in one place and shouldn't generally be used, you can add an item in an appropriate file in .github/actions/spell-check/patterns/.

See the README.md in each directory for more information.

🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The :check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉

⚠️ Reviewers

At present, the action that triggered this message will not show its ❌ in this PR unless the branch is within this repository.
Thus, you should make sure that this comment has been addressed before encouraging the merge bot to merge this PR.

@Don-Vito Don-Vito marked this pull request as draft November 8, 2020 06:28
@Don-Vito Don-Vito marked this pull request as ready for review November 8, 2020 09:40
@ghost
Copy link

ghost commented Nov 8, 2020

It looks good to me!

@Don-Vito
Copy link
Contributor Author

Don-Vito commented Nov 8, 2020

It looks good to me!

@Hegunumo - thanks a lot!

Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this approach. Thanks!

@DHowett DHowett changed the title 8189: Command Palette: page up/down "wrap" backwards when you're too close to the bottom of the list Don't let PageUp/PageDown wrap in the command palette Nov 9, 2020
@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Nov 9, 2020
@ghost
Copy link

ghost commented Nov 9, 2020

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@DHowett
Copy link
Member

DHowett commented Nov 9, 2020

Oi, there's a conflict now!

@DHowett DHowett changed the title Don't let PageUp/PageDown wrap in the command palette Teach the command palette to clamp its indices on page up/down Nov 9, 2020
@Don-Vito
Copy link
Contributor Author

Don-Vito commented Nov 9, 2020

Oi, there's a conflict now!

Solving it at this moment 😊 Especially fun, as it is a conflict with myself.

@ghost ghost removed the AutoMerge Marked for automatic merge by the bot when requirements are met label Nov 9, 2020
@Don-Vito Don-Vito requested a review from DHowett November 9, 2020 20:09
@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Nov 9, 2020
@DHowett DHowett merged commit 624d07f into microsoft:main Nov 9, 2020
DHowett pushed a commit that referenced this pull request Nov 9, 2020
This commit will teach CommandPalette to clamp the scroll page up and
scroll page down navigation so as to not wrap.

Closes #8189

(cherry picked from commit 624d07f)
@ghost
Copy link

ghost commented Nov 11, 2020

🎉Windows Terminal v1.4.3141.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Nov 11, 2020

🎉Windows Terminal Preview v1.5.3142.0 has been released which incorporates this pull request.:tada:

Handy links:

@Don-Vito Don-Vito deleted the 8189-clamp-command-palette-navigation branch December 3, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command Palette: page up/down "wrap" backwards when you're too close to the bottom of the list
3 participants