Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine the parsing & dispatch blocks for OSC actions #8202

Merged
1 commit merged into from
Nov 11, 2020
Merged

Combine the parsing & dispatch blocks for OSC actions #8202

1 commit merged into from
Nov 11, 2020

Conversation

PankajBhojwani
Copy link
Contributor

@PankajBhojwani PankajBhojwani commented Nov 9, 2020 •
edited by DHowett
Loading

In ActionOscDispatch() in OutputStateMachineEngine.cpp, we had a
section for parsing and another section for dispatching. This PR
combines those two blocks since they do not need to be distinct.

Validation Steps Performed

TerminalApiTests still pass

@skyline75489
Copy link
Collaborator

I like this 😄

@zadjii-msft zadjii-msft self-assigned this Nov 10, 2020
zadjii-msft
zadjii-msft approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea this looks better now that the other dispatch methods in this file are written like this too.

@zadjii-msft zadjii-msft removed their assignment Nov 10, 2020
@zadjii-msft zadjii-msft added Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Area-VT Virtual Terminal sequence support labels Nov 10, 2020
@DHowett DHowett changed the title Combine the parsing and dispatch blocks for OSC action processing Combine the parsing & dispatch blocks for OSC actions Nov 11, 2020
DHowett
DHowett approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it

@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Nov 11, 2020
@ghost
Copy link

ghost commented Nov 11, 2020

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit c0b1fe0 into main Nov 11, 2020
@ghost ghost deleted the dev/pabhoj/osc_parse branch November 11, 2020 02:27
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Area-VT Virtual Terminal sequence support AutoMerge Marked for automatic merge by the bot when requirements are met
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PankajBhojwani @skyline75489 @DHowett @zadjii-msft