Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid an access violation in pane animation if the child is closed #8218

Merged
1 commit merged into from
Nov 10, 2020
Merged

Avoid an access violation in pane animation if the child is closed #8218

1 commit merged into from
Nov 10, 2020

Conversation

Don-Vito
Copy link
Contributor

@Don-Vito Don-Vito commented Nov 10, 2020 •
edited by DHowett
Loading

Some UTs crash with access violation, that occurs during pane animation.
The reason for this is a race, upon which the pane is closed (set to
nullptr) before the parent is animated. Added a simple check against
null. Doubt it can happen in production, yet worth taking care!

@Don-Vito
Copy link
Contributor Author

@DHowett - do I need to create a ticket for such and issue a formal PR.. or can I simply push the PR?

@Don-Vito Don-Vito changed the title Access Violation in UTs - check the child pane was not closed, during the opening animation Access Violation in pane animation if the child is closed (reproduces in UT) Nov 10, 2020
@Don-Vito Don-Vito changed the title Access Violation in pane animation if the child is closed (reproduces in UT) Access Violation in pane animation if the child is closed (random UT crash) Nov 10, 2020
@zadjii-msft
Copy link
Member

Usually if we file an issue for something like this, it's because we don't plan on investigating it immediately, and don't want to forget about it 😛 For something like this, if you've already got a beat on a fix, just push the PR.

@carlos-zamora carlos-zamora added the AutoMerge Marked for automatic merge by the bot when requirements are met label Nov 10, 2020
@ghost
Copy link

ghost commented Nov 10, 2020

Hello @carlos-zamora!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 23 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

DHowett
DHowett approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@DHowett DHowett changed the title Access Violation in pane animation if the child is closed (random UT crash) Access Violation in pane animation if the child is closed Nov 10, 2020
@DHowett DHowett changed the title Access Violation in pane animation if the child is closed Avoid an access violation in pane animation if the child is closed Nov 10, 2020
@DHowett
Copy link
Member

DHowett commented Nov 10, 2020

@msftbot merge this in 1 minute

@ghost
Copy link

ghost commented Nov 10, 2020

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Tue, 10 Nov 2020 23:25:17 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 5a942bc into microsoft:main Nov 10, 2020
@Don-Vito Don-Vito deleted the fix-pane-animation-crash branch December 3, 2020 17:03
DHowett pushed a commit that referenced this pull request Jan 25, 2021
@Don-Vito @DHowett
Avoid an access violation in pane animation if the child is closed (#…
431559f 
…8218)

Some UTs crash with access violation, that occurs during pane animation.
The reason for this is a race, upon which the pane is closed (set to
nullptr) before the parent is animated.  Added a simple check against
null.  Doubt it can happen in production, yet worth taking care!

(cherry picked from commit 5a942bc)
@ghost
Copy link

ghost commented Jan 28, 2021

🎉Windows Terminal v1.5.10271.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jan 28, 2021

🎉Windows Terminal Preview v1.6.10272.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Don-Vito @zadjii-msft @DHowett @carlos-zamora