Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Tab tooltip explicitly #8298

Merged
8 commits merged into from Dec 17, 2020
Merged

Set Tab tooltip explicitly #8298

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
aea4c15
update for TabHeaderControl
kaihugo Dec 4, 2020
96da7f8
delete the line from last the PR(8194)
kaihugo Dec 4, 2020
127eeb1
code format
kaihugo Dec 4, 2020
96e77bb
avoid the Run and TextBlock
kaihugo Dec 15, 2020
7a73a8f
not this PR
kaihugo Dec 15, 2020
9eba428
remove _SetToolTip from UpdateTitle()
kaihugo Dec 15, 2020
dffe560
Put it back into UpdateTitle()
kaihugo Dec 15, 2020
52517c4
improve readability
kaihugo Dec 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/cascadia/TerminalApp/TerminalTab.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ namespace winrt::TerminalApp::implementation
tab->SetTabText(title);
}
});

// Use our header control as the TabViewItem's header
TabViewItem().Header(_headerControl);
}
Expand All @@ -71,6 +70,13 @@ namespace winrt::TerminalApp::implementation
_RecalculateAndApplyTabColor();
}

void TerminalTab::_SetToolTip(const winrt::hstring& tabTitle)
{
auto toolTip = WUX::Controls::ToolTip{};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
auto toolTip = WUX::Controls::ToolTip{};
WUX::Controls::ToolTip toolTip{};

optional change to improve code readability. we usually don't use "auto x = type{y}" because auto is only good when you don't have to say the type. type x{y}; is shorter 😄

toolTip.Content(winrt::box_value(tabTitle));
WUX::Controls::ToolTipService::SetToolTip(TabViewItem(), toolTip);
}

// Method Description:
// - Returns nullptr if no children of this tab were the last control to be
// focused, or the TermControl that _was_ the last control to be focused (if
Expand Down Expand Up @@ -231,6 +237,7 @@ namespace winrt::TerminalApp::implementation

// Update the control to reflect the changed title
_headerControl.Title(activeTitle);
_SetToolTip(activeTitle);
}
}

Expand Down
2 changes: 2 additions & 0 deletions src/cascadia/TerminalApp/TerminalTab.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,8 @@ namespace winrt::TerminalApp::implementation

void _MakeTabViewItem();

void _SetToolTip(const winrt::hstring& tabTitle);

void _CreateContextMenu() override;

void _RefreshVisualState();
Expand Down