Add size param to splitPane action, split-pane subcommand
#8543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, you say, 'Let's add some tests,' they say, 'Heck no, I don't like no tests'?
ghost
added
Area-Commandline
zadjii-msft
added a commit
to MicrosoftDocs/terminal
that referenced
this pull request
Dec 15, 2020
DHowett
reviewed
Dec 15, 2020
DHowett
approved these changes
Dec 15, 2020
ghost
requested review from
miniksa,
carlos-zamora,
leonMSFT and
PankajBhojwani
carlos-zamora
approved these changes
Dec 17, 2020
| @@ -147,7 +148,8 @@ namespace SettingsModelLocalTests | |||
| { "name": "command1", "command": { "action": "splitPane", "split": "vertical" } }, | |||
| { "name": "command2", "command": { "action": "splitPane", "split": "horizontal" } }, | |||
| { "name": "command4", "command": { "action": "splitPane" } }, | |||
| { "name": "command5", "command": { "action": "splitPane", "split": "auto" } } | |||
| { "name": "command5", "command": { "action": "splitPane", "split": "auto" } }, | |||
There was a problem hiding this comment.
nit: maybe add a test for "split" and "size" both defined?
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
2 tasks
ghost
pushed a commit
that referenced
this pull request
Jan 12, 2021
## Summary of the Pull Request I forgot to reset the `--size` argument to `split-pane` when I added it. This PR fixes that, and adds a test so I don't regress it again. ## References * Missed in #8543 ## PR Checklist * [x] I work here * [x] Tests added/passed
15 tasks
|
🎉 Handy links: |
ghost
mentioned this pull request
mpela81
pushed a commit
to mpela81/terminal
that referenced
this pull request
Jan 28, 2021
…osoft#8543) ## Summary of the Pull Request Adds a `size` parameter to `splitPane`. This takes a `float`, and specifies the portion of the parent pane that should be used to create the new one. This also adds the param to the `split-pane` subcommand. ### Examples | commandline | result | | -- | -- | | `wt ; sp -s .25` |  | | `wt ; sp -s .8` |  | | `wt ; sp -s .8 ; sp -H -s .3` |  | ## PR Checklist * [x] Closes microsoft#6298 * [x] I work here * [x] Tests added/passed * [x] Docs PR: MicrosoftDocs/terminal#208 ## Detailed Description of the Pull Request / Additional comments I went with `size`, `--size,-s` rather than `percent`, because the arg is the (0,1) version of the size, not the (0%,100%) version. ## Validation Steps Performed Added actions, played with the commandline, ran tests
mpela81
pushed a commit
to mpela81/terminal
that referenced
this pull request
Jan 28, 2021
## Summary of the Pull Request I forgot to reset the `--size` argument to `split-pane` when I added it. This PR fixes that, and adds a test so I don't regress it again. ## References * Missed in microsoft#8543 ## PR Checklist * [x] I work here * [x] Tests added/passed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Adds a
sizeparameter tosplitPane. This takes afloat, and specifies the portion of the parent pane that should be used to create the new one.This also adds the param to the
split-panesubcommand.Examples
wt ; sp -s .25wt ; sp -s .8wt ; sp -s .8 ; sp -H -s .3PR Checklist
wt.exeshould support-%,--percentfor setting a pane's size on the commandline #6298sizeparam ofsplitPaneaction MicrosoftDocs/terminal#208Detailed Description of the Pull Request / Additional comments
I went with
size,--size,-srather thanpercent, because the arg is the (0,1) version of the size, not the (0%,100%) version.Validation Steps Performed
Added actions, played with the commandline, ran tests