Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Select all shortcut action #8557

Closed
wants to merge 3 commits into from
Closed

Add Select all shortcut action #8557

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 11, 2020

Summary of the Pull Request

With this PR, users could select all the text in current buffer.

References

PR Checklist

  • Closes Ability to select/copy all the text in the session #1469
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@ghost ghost added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. labels Dec 11, 2020
@zadjii-msft
Copy link
Member

Hey @Hegunumo,

Thanks for throwing this one together! Unfortunately we're kinda planning on going in another direction on this one. We've actually already got a spec open (#2840), and a draft implementation (#3758) for keyboard text selection. Those two cover not only selecting all the text in the buffer, but a bunch of other scenarios as well. I think #1469 was accidentally left marked help-wanted. Sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to select/copy all the text in the session
2 participants
@zadjii-msft @kaihugo