-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce search status #8588
Closed
Closed
Introduce search status #8588
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
fa06c6f
Introduce search status
Don-Vito ff1558c
Teach search box to update status when new output is written
Don-Vito 5391f4e
Remove live-search feature flag
Don-Vito 81a4a31
Merge remote-tracking branch 'upstream/main' into 6319-search-status
Don-Vito 4ab4d41
Allow disabling navigation buttons in SearchBox
Don-Vito 4a2de19
Add Searching status to translation
Don-Vito fe59504
Run search in the background + itnroduce grace for next search
Don-Vito 1068f85
Merge branch 'main' into 6319-search-status
Don-Vito 8e5efb7
Introduce computation of required statusbox width
Don-Vito 160716d
Reduce the value :)
Don-Vito File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -53,7 +53,7 @@ | |
<SolidColorBrush x:Key="TextControlBorderBrushFocused" Color="#404040"/> | ||
<SolidColorBrush x:Key="TextControlButtonForegroundPressed" Color="#FFFFFF"/> | ||
<SolidColorBrush x:Key="TextControlButtonBackgroundPressed" Color="#FF4343"/> | ||
|
||
<!-- ToggleButton colors !--> | ||
<SolidColorBrush x:Key="ToggleButtonForeground" Color="#B5B5B5"/> | ||
|
||
|
@@ -161,8 +161,16 @@ | |
KeyDown="TextBoxKeyDown" | ||
Margin="5" | ||
HorizontalAlignment="Left" | ||
VerticalAlignment="Center"> | ||
VerticalAlignment="Center" | ||
TextChanged="TextBoxTextChanged"> | ||
</TextBox> | ||
<TextBlock x:Name="StatusBox" | ||
x:Uid="SearchBox_StatusBox" | ||
FontSize="15" | ||
Margin="5" | ||
HorizontalAlignment="Left" | ||
VerticalAlignment="Center"> | ||
</TextBlock> | ||
|
||
<ToggleButton x:Name="GoBackwardButton" | ||
x:Uid="SearchBox_SearchBackwards" | ||
|
@@ -181,7 +189,8 @@ | |
|
||
<ToggleButton x:Name="CaseSensitivityButton" | ||
x:Uid="SearchBox_CaseSensitivity" | ||
Style="{StaticResource ToggleButtonStyle}"> | ||
Style="{StaticResource ToggleButtonStyle}" | ||
Click="CaseSensitivityButtonClicked"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. does this also trigger for keyboard activation? is there another event on ToggleButton that we can listen to for it being toggled? |
||
<PathIcon Data="M8.87305 10H7.60156L6.5625 7.25195H2.40625L1.42871 10H0.150391L3.91016 0.197266H5.09961L8.87305 10ZM6.18652 6.21973L4.64844 2.04297C4.59831 1.90625 4.54818 1.6875 4.49805 1.38672H4.4707C4.42513 1.66471 4.37272 1.88346 4.31348 2.04297L2.78906 6.21973H6.18652ZM15.1826 10H14.0615V8.90625H14.0342C13.5465 9.74479 12.8288 10.1641 11.8809 10.1641C11.1836 10.1641 10.6367 9.97949 10.2402 9.61035C9.84831 9.24121 9.65234 8.7513 9.65234 8.14062C9.65234 6.83268 10.4225 6.07161 11.9629 5.85742L14.0615 5.56348C14.0615 4.37402 13.5807 3.7793 12.6191 3.7793C11.776 3.7793 11.015 4.06641 10.3359 4.64062V3.49219C11.0241 3.05469 11.8171 2.83594 12.7148 2.83594C14.36 2.83594 15.1826 3.70638 15.1826 5.44727V10ZM14.0615 6.45898L12.373 6.69141C11.8535 6.76432 11.4616 6.89421 11.1973 7.08105C10.9329 7.26335 10.8008 7.58919 10.8008 8.05859C10.8008 8.40039 10.9215 8.68066 11.1631 8.89941C11.4092 9.11361 11.735 9.2207 12.1406 9.2207C12.6966 9.2207 13.1546 9.02702 13.5146 8.63965C13.8792 8.24772 14.0615 7.75326 14.0615 7.15625V6.45898Z"/> | ||
</ToggleButton> | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a complicated version of
MaxWidth
. Any opportunity for simplification?