Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teach terminal page to go to the last used tab in MRU mode #8610

Merged
2 commits merged into from
Dec 18, 2020
Merged

Teach terminal page to go to the last used tab in MRU mode #8610

2 commits merged into from
Dec 18, 2020

Conversation

Don-Vito
Copy link
Contributor

@Don-Vito Don-Vito commented Dec 18, 2020 •
edited by DHowett
Loading

PR Checklist

@ghost ghost added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Dec 18, 2020
DHowett
DHowett approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm quite comfortable with this change in behavior. Great catch!

@DHowett
Copy link
Member

DHowett commented Dec 18, 2020

@msftbot make sure @zadjii-msft signs off

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Dec 18, 2020
@ghost
Copy link

ghost commented Dec 18, 2020

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I'll only merge this pull request if it's approved by @zadjii-msft

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@zadjii-msft zadjii-msft mentioned this pull request Dec 18, 2020
Open
34 tasks
zadjii-msft
zadjii-msft approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems reasonable to me, thanks!

@ghost ghost merged commit 96b9ba9 into microsoft:main Dec 18, 2020
@ghost
Copy link

ghost commented Jan 28, 2021

🎉Windows Terminal Preview v1.6.10272.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jan 28, 2021
Closed
mpela81 pushed a commit to mpela81/terminal that referenced this pull request Jan 28, 2021
@Don-Vito @mpela81
Teach terminal page to go to the last used tab in MRU mode (microsoft…
3a8b8be 
…#8610)

## PR Checklist
* [x] Closes microsoft#8550
* [x] CLA signed. 
* [ ] Tests added/passed
* [ ] Documentation updated. 
* [ ] Schema updated.
* [x] I've discussed this with core contributors already.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MRU mode: when you close a tab, it goes to the nearest adjacent instead of the last used
3 participants
@Don-Vito @DHowett @zadjii-msft