-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable underlining hyperlink on hover even if not focused #8615
Conversation
What happened? We aren’t ignoring you, the team is on vacation for the rest of the year. You can leave your pull request open and we will review it when we are back in the office! |
@@ -1344,8 +1344,10 @@ namespace winrt::Microsoft::Terminal::TerminalControl::implementation | |||
|
|||
const auto ptr = args.Pointer(); | |||
const auto point = args.GetCurrentPoint(*this); | |||
const auto cursorPosition = point.Position(); | |||
const auto terminalPosition = _GetTerminalPosition(cursorPosition); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: with these 2 declarations here, the cursorPosition
and terminalPos
declarations below (lines 1369 and 1412) can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, but I agree with Pankaj. We should remove the redundant declarations below now.
I made the requested changes. This PR is 20 days old and I don't want to make @Hegunumo spend another cycle on it. 😄 |
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
🎉 Handy links: |
Closes #8475