Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate more transient allocations: Titles and invalid rectangles and bitmap runs and utf8 conversions #8621

Merged
23 commits merged into from
Feb 16, 2021
Merged

Eliminate more transient allocations: Titles and invalid rectangles and bitmap runs and utf8 conversions #8621

23 commits merged into from
Feb 16, 2021

Commits on Dec 19, 2020

  1. We never look at just the prefix. So store Title+Prefix concatenated … 

    …so it's not assembled every time the renderer asks.
    @miniksa
    miniksa committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    60bbf49 View commit details
    Browse the repository at this point in the history

  2. Finish fixing title. Change all Dirty Areas to be stored in the engin… 

    …es and returned as iterable spans to avoid more allocations, especially for renderers with complex dirty areas that are already storing the rectangles internally.
    @miniksa
    miniksa committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    be5da8d View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2021

  1. Make it use wstring_view

    @miniksa
    miniksa committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    f66d51e View commit details
    Browse the repository at this point in the history

  2. These should be string views to match.

    @miniksa
    miniksa committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    2983b9d View commit details
    Browse the repository at this point in the history

  3. Code format!

    @miniksa
    miniksa committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    b2e6d6d View commit details
    Browse the repository at this point in the history

  4. static analysis

    @miniksa
    miniksa committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    50e8ee8 View commit details
    Browse the repository at this point in the history

  5. fix test things too.

    @miniksa
    miniksa committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    141bbd9 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into dev/miniksa/perf_title_and_dirty

    @miniksa
    miniksa committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    ead8fab View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2021

  1. Add held-buffer converter helpers for hot paths.

    @miniksa
    miniksa committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    00f80e4 View commit details
    Browse the repository at this point in the history

  2. Hold a conversion buffer string on the VtEngine to prevent hundreds o… 

    …f thousands of transient allocations as we convert things to emit them as a UTF-8 string.
    @miniksa
    miniksa committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    d8cbaed View commit details
    Browse the repository at this point in the history

  3. use PMR pool for the vector in the bitmap so we're not alloc/freeing … 

    …over and over when we know we're about to just rebuild a vector of more runs. optional will destroy the internal vector.
    @miniksa
    miniksa committed Jan 8, 2021
    1 Configuration menu
    Copy the full SHA
    1882623 View commit details
    Browse the repository at this point in the history

  4. Revert "Hold a conversion buffer string on the VtEngine to prevent hu… 

    …ndreds of thousands of transient allocations as we convert things to emit them as a UTF-8 string."

This reverts commit d8cbaed.
    @miniksa
    miniksa committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    f378785 View commit details
    Browse the repository at this point in the history

  5. Use u16u8 instead of reinventing the wheel on out parameters for conv… 

    …ersion.
    @miniksa
    miniksa committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    0f4d33b View commit details
    Browse the repository at this point in the history

  6. code format!'

    @miniksa
    miniksa committed Jan 8, 2021
    1 Configuration menu
    Copy the full SHA
    1d977b7 View commit details
    Browse the repository at this point in the history

  7. Validated in razzle. Forgot to declare the rectangle in bgfx engine.

    @miniksa
    miniksa committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    8221b22 View commit details
    Browse the repository at this point in the history

  8. Spell check. codepath --> code path.

    @miniksa
    miniksa committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    9fefabf View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2021

  1. missed a noexcept for audit mode.

    @miniksa
    miniksa committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    fa1e14a View commit details
    Browse the repository at this point in the history

  2. Don't bother adding these functions to Convert since I didn't use 'em… 

    … in the end going for til instead.
    @miniksa
    miniksa committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    ebbda64 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2021

  1. Fixed it I think.

    @miniksa
    miniksa committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    1929b32 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2021

  1. Merge branch 'main' into dev/miniksa/perf_title_and_dirty

    @miniksa
    miniksa committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    7662ea8 View commit details
    Browse the repository at this point in the history

  2. ensure that PMR is being used now that it's not strictly a part of th… 

    …e header.
    @miniksa
    miniksa committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    c6432ae View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2021

  1. Reorder constructors for bitmap how they are in main. Use the three-p… 

    …arameter constructor in VT because the compiler matches the &_pool on the two-part one to a boolean!
    @miniksa
    miniksa committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    a6f1b49 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2021

  1. CODE FORMAT!!!!

    @miniksa
    miniksa committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    b308974 View commit details
    Browse the repository at this point in the history