-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make "open terminal here" context menu work for directory background #8638
Conversation
use win32 explorer window to find current directory folder path link user32.lib disable vcpkg use nuget packages
New misspellings found, please review:
To accept these changes, run the following commands
✏️ Contributor please read thisBy default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.
If the listed items are:
See the 🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The :check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉
|
WOW! This is clever! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting some minor changes. This is awesome though, thanks!
.github/actions/spell-check/expect/a129ff14ec985d6b7bf09e296a831c955d41040b.txt
Show resolved
Hide resolved
Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com>
Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I love how clever this is. I've got a bunch of basically nits, but largely this seems good to me. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will need to update the other two appxmanifest
files in the src/Cascadia/CascadiaPackage
directory. They are used for the Release and Preview versions!
Awaiting!! It would be better if the right-click menu option had localization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've chatted with the team who owns explorer shell extensions, and they have conceded that they will accept this workaround. Thanks so much, this is a very clever solution. I love it.
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Awesome :) glad it helps. |
…8638) This commit makes "Open in Windows Terminal" Context menu work again for directory background even on system that OS fix is not applied. This is a fallback solution to OS fixes mentioned in #6414. While OS fix is on its way, we need a fallback that works on existing OS versions. The approach to this is: when no item is selected (nullptr for IShellItemArray*), we use shell api to query the path of current active Explorer window. A special case is handled for Windows Desktop. Once we are able to obtain the path, we launch Windows Terminal with it. 1. Right click on desktop to bring up the Context menu, pick "Open in Windows Terminal", verify that a terminal is opened with correct initial path. 2. Open a few File Explorer windows, pick any window, navigate to a folder, click on "Background" to bring up the context menu, click "Open in Windows Terminal" verify that a terminal is opened with correct initial path. Closes #6414 (cherry picked from commit fcca88a)
🎉 Handy links: |
🎉 Handy links: |
…icrosoft#8638) This commit makes "Open in Windows Terminal" Context menu work again for directory background even on system that OS fix is not applied. This is a fallback solution to OS fixes mentioned in microsoft#6414. While OS fix is on its way, we need a fallback that works on existing OS versions. The approach to this is: when no item is selected (nullptr for IShellItemArray*), we use shell api to query the path of current active Explorer window. A special case is handled for Windows Desktop. Once we are able to obtain the path, we launch Windows Terminal with it. ## Validation Steps Performed 1. Right click on desktop to bring up the Context menu, pick "Open in Windows Terminal", verify that a terminal is opened with correct initial path. 2. Open a few File Explorer windows, pick any window, navigate to a folder, click on "Background" to bring up the context menu, click "Open in Windows Terminal" verify that a terminal is opened with correct initial path. Closes microsoft#6414
Fix a bug brought in with PR: #8638 see, #8936 #8638 * [x] Closes #8936 * [x] CLA signed * [x] Tests passed With the help from @nc-x, the issue is reproduced and fixed by this patch. CLSCTX_IN_PROCESS is not good enough for all cases to create IShellWindows interface. Put a CLSCTX_ALL fixes the issue. Another debugging warning dialogs for reusing not null com_ptr in the loop is fixed too. (This was shown in debug builds only)
Fix a bug brought in with PR: #8638 see, #8936 #8638 * [x] Closes #8936 * [x] CLA signed * [x] Tests passed With the help from @nc-x, the issue is reproduced and fixed by this patch. CLSCTX_IN_PROCESS is not good enough for all cases to create IShellWindows interface. Put a CLSCTX_ALL fixes the issue. Another debugging warning dialogs for reusing not null com_ptr in the loop is fixed too. (This was shown in debug builds only) (cherry picked from commit e207236)
Fix a bug brought in with PR: #8638 see, #8936 #8638 * [x] Closes #8936 * [x] CLA signed * [x] Tests passed With the help from @nc-x, the issue is reproduced and fixed by this patch. CLSCTX_IN_PROCESS is not good enough for all cases to create IShellWindows interface. Put a CLSCTX_ALL fixes the issue. Another debugging warning dialogs for reusing not null com_ptr in the loop is fixed too. (This was shown in debug builds only) (cherry picked from commit e207236)
This commit makes "Open in Windows Terminal" Context menu work again for
directory background even on system that OS fix is not applied.
This is a fallback solution to OS fixes mentioned in #6414.
While OS fix is on its way, we need a fallback that works on existing OS
versions.
The approach to this is: when no item is selected (nullptr for
IShellItemArray*), we use shell api to query the path of current active
Explorer window. A special case is handled for Windows Desktop. Once
we are able to obtain the path, we launch Windows Terminal with it.
Validation Steps Performed
Right click on desktop to bring up the Context menu, pick "Open in
Windows Terminal", verify that a terminal is opened with correct
initial path.
Open a few File Explorer windows, pick any window, navigate to a
folder, click on "Background" to bring up the context menu, click
"Open in Windows Terminal" verify that a terminal is opened with
correct initial path.
Closes #6414