Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Represent inheritance in Settings UI #8919

Merged
18 commits merged into from
Feb 8, 2021
Merged

Represent inheritance in Settings UI #8919

18 commits merged into from
Feb 8, 2021

Commits on Jan 28, 2021

  1. Introduce SettingContainer to Settings UI

    @carlos-zamora
    carlos-zamora committed Jan 28, 2021
    1 Configuration menu
    Copy the full SHA
    19fe2be View commit details
    Browse the repository at this point in the history

  2. spell check

    @carlos-zamora
    carlos-zamora committed Jan 28, 2021
    1 Configuration menu
    Copy the full SHA
    74a53f8 View commit details
    Browse the repository at this point in the history

  3. apply PR feedback

    @carlos-zamora
    carlos-zamora committed Jan 28, 2021
    1 Configuration menu
    Copy the full SHA
    75cdbd0 View commit details
    Browse the repository at this point in the history

  4. btn --> button

    @carlos-zamora
    carlos-zamora committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    7baf80c View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2021

  1. apply some more PR feedback

    @carlos-zamora
    carlos-zamora committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    e1499d8 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2021

  1. Remove unnecessary auto props (verified)

    @carlos-zamora
    carlos-zamora committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    59acec0 View commit details
    Browse the repository at this point in the history

  2. fix base layer

    @carlos-zamora
    carlos-zamora committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    c2a4858 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2021

  1. more polish

    @carlos-zamora
    carlos-zamora committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    5185372 View commit details
    Browse the repository at this point in the history

  2. use SettingContainer throughout Global settings too

    @carlos-zamora
    carlos-zamora committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    e7ce161 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2021

  1. lazy load dependency properties

    @carlos-zamora
    carlos-zamora committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    17bbcf4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into dev/cazamor/sui/setting-container

    @carlos-zamora
    carlos-zamora committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    418db46 View commit details
    Browse the repository at this point in the history

  3. polish override msg generation

    @carlos-zamora
    carlos-zamora committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    a4aac54 View commit details
    Browse the repository at this point in the history

  4. polish last bit of relevant auto props for this PR

    @carlos-zamora
    carlos-zamora committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    207ac13 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2021

  1. stuff override msg in reset button

    @carlos-zamora
    carlos-zamora committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    0ad0bd0 View commit details
    Browse the repository at this point in the history

  2. bonus points: automatically move focus on reset button click

    @carlos-zamora
    carlos-zamora committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    e799167 View commit details
    Browse the repository at this point in the history

  3. const auto& spree

    @carlos-zamora
    carlos-zamora committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    e9c7fb4 View commit details
    Browse the repository at this point in the history

  4. add AP to Delete btn; fix keyboard navigation

    @carlos-zamora
    carlos-zamora committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    f53bc09 View commit details
    Browse the repository at this point in the history

  5. apply code suggestion

    @carlos-zamora
    carlos-zamora committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    824ff79 View commit details
    Browse the repository at this point in the history