Add support for "focus follows mouse" mode

[Don-Vito]

PR Checklist

• Closes Pane focus follows mouse #6459
• CLA signed.
• Tests added/passed
• Documentation updated here: Document Focus-Follow-Mouse setting MicrosoftDocs/terminal#248
• Schema updated.
• I've discussed this with core contributors already.

[Gursu78]

Merhaba Hata kodu 0X80092012 Unknow Error .bunu nasıl çözemedim.

[Don-Vito]

Merhaba Hata kodu 0X80092012 Unknow Error .bunu nasıl çözemedim.

@Gursu78 - Hata açıklaması içeren bir bilet açmanız gerekiyor. Rastgele bir PR ile yazmak yerine

[Don-Vito]

@zadjii-msft - WDYT?

[zadjii-msft]

So yea, this would definitely work for "focus follows mouse". I hate to be that guy though - I think this needs to be a (global) setting. I don't think I'd personally want this setting on, though it's definitely a good idea.

If this is a setting, then we'd need another way of fixing #8925 regardless if the setting was enabled or not. I'm gonna block for discussion, but the implementation is sound.

[Don-Vito]

So yea, this would definitely work for "focus follows mouse". I hate to be that guy though - I think this needs to be a (global) setting. I don't think I'd personally want this setting on, though it's definitely a good idea.

If this is a setting, then we'd need another way of fixing #8925 regardless if the setting was enabled or not. I'm gonna block for discussion, but the implementation is sound.

So I will also be that guy 😄 - if the user selects not to use "focus follow mouse", they will need to focus the pane to get the hyperlink instead of #8475.

WDYT?

Agree regarding the setting (planned to add it once you agree with the idea)

[Don-Vito]

@zadjii-msft - WDYT about my previous comment.
Also should I add a setting and productize it?

[zadjii-msft]

Oh. Well that's annoying. I figured there'd still be a way to get the unfocused hyperlink hovering to work, even without focus follows mouse.

The team did discuss this and came to the conclusion that "focus follows mouse" would definitely have to be a setting, probably defaulted to false. You okay with that?

[Don-Vito]

Oh. Well that's annoying. I figured there'd still be a way to get the unfocused hyperlink hovering to work, even without focus follows mouse.

The team did discuss this and came to the conclusion that "focus follows mouse" would definitely have to be a setting, probably defaulted to false. You okay with that?

@zadjii-msft - I can absolutely solve #8925 separately from this PR. I assumed that probably the users who want to interact with other panes, will also want them focused.

If this is not the case I will

• Add this with a setting defaulted to false.
• Create another PR that unselects hyperlinks in non-focused tabs.

BTW I am somewhat worried with the current solution, as right now we send a mouse input when hovering over unfocused panes. Is it intentional?

[zadjii-msft]

I am somewhat worried with the current solution, as right now we send a mouse input when hovering over unfocused panes. Is it intentional?

😬 almost certainly not

[Don-Vito]

So yea, this would definitely work for "focus follows mouse". I hate to be that guy though - I think this needs to be a (global) setting. I don't think I'd personally want this setting on, though it's definitely a good idea.

If this is a setting, then we'd need another way of fixing #8925 regardless if the setting was enabled or not. I'm gonna block for discussion, but the implementation is sound.

@zadjii-msft -

• I decoupled this from De-underline hyperlink on hover-out, even if not focused #8925 (I will issue a PR for it separately). So now we only introduce FFM
• Introduced a setting (defaulted to false)

Please review (if you like it, I will add a documentation)

[zadjii-msft]

that-was-easy.jpg

[Don-Vito]

I guess it will continue getting conflicts as I added a setting to the end 😄
@zadjii-msft - is anyone assigned to take a second look or everybody hates this feature? 😄

[zadjii-msft]

Oh, just I think the rest of the team is a little bogged down...

oh wait nope, nevermind. I never threw Needs-Second on this. My b.

[carlos-zamora]

A few things:

• If the window is not focused, does it get focus when we hover over a terminal?
• If the tab switcher or command palette is open, does this immediately close it because the terminal gets focus? Or what happens?
• How does this work when the search box is open in multiple panes?
• Update the schema please.
• I have no issues with this being a setting. So please make a PR for the docs repo too 😊

[Don-Vito]

A few things:

* If the window is not focused, does it get focus when we hover over a terminal?

Nope. The window will remain unfocused. But the pane will become active. Looks good to me, but let me know if you see otherwise.

* If the tab switcher or command palette is open, does this immediately close it because the terminal gets focus? Or what happens?

The CmdPal/ATS remain open as they "hide" the terminal behind them (no pointer move is reported)

* How does this work when the search box is open in multiple panes?

In this case the behavior is similar as if you were clicking on the second pane. This one is somewhat questionable. WDYT?

* Update the schema please.

Done.

* I have no issues with this being a setting. So please make a PR for the docs repo too 😊

Doing it right now. Might introduce some extra / miss some "the" 😊

[carlos-zamora]

Thanks for looking into those scenarios! I think they're all fine. The search box one is somewhat questionable but I think this makes more sense than closing/ignoring the search box on hover.

[ghost]

Hello @carlos-zamora!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[ghost]

🎉Windows Terminal Preview v1.7.572.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download