Manually initialize the warnings vector to prevent a crash on launch #8995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Settings
|
@DHowett INTERESTING, the bot did not transfer the z*Service-Consider labels, headsup |
|
Thanks for the h/u. What the heck did spellbot drink? |
DHowett
approved these changes
Feb 1, 2021
| @@ -2410,7 +2410,7 @@ namespace winrt::TerminalApp::implementation | |||
| IVectorView<Profile> profiles, | |||
| IMapView<winrt::hstring, ColorScheme> schemes) | |||
| { | |||
| IVector<SettingsLoadWarnings> warnings; | |||
| IVector<SettingsLoadWarnings> warnings{ winrt::single_threaded_vector<SettingsLoadWarnings>() }; | |||
There was a problem hiding this comment.
I hate that we're heap allocating a thing that in most instances will not be used at all, but it fixes a bug and I cannot die on the hill of purity.
DHowett
added
AutoMerge
|
Hello @DHowett! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 56 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
carlos-zamora
approved these changes
Feb 1, 2021
ghost
deleted the
dev/migrie/b/8986-why-would-you-do-this-colorschemes
branch
DHowett
removed
zStable-Service-Queued-1.12
DHowett
pushed a commit
that referenced
this pull request
Feb 5, 2021
…8995) ## Summary of the Pull Request Oops, winrt `IVector`s need to be manually initialized, when default-constructed `std::vector`s didn't. Simple oversight. ## PR Checklist * [x] Closes #8986 * [x] I work here * [x] A test would be great but ain't nobody got time for that. * [n/a] Requires documentation to be updated ## Validation Steps Performed Ran the terminal with ```json "schemes" : [ {} ] ``` First the crash repro'd, now it doesn't. (cherry picked from commit 9d71fa8)
DHowett
pushed a commit
that referenced
this pull request
Feb 5, 2021
…8995) ## Summary of the Pull Request Oops, winrt `IVector`s need to be manually initialized, when default-constructed `std::vector`s didn't. Simple oversight. ## PR Checklist * [x] Closes #8986 * [x] I work here * [x] A test would be great but ain't nobody got time for that. * [n/a] Requires documentation to be updated ## Validation Steps Performed Ran the terminal with ```json "schemes" : [ {} ] ``` First the crash repro'd, now it doesn't. (cherry picked from commit 9d71fa8)
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Oops, winrt
IVectors need to be manually initialized, when default-constructedstd::vectors didn't. Simple oversight.PR Checklist
Validation Steps Performed
Ran the terminal with
"schemes" : [ {} ]First the crash repro'd, now it doesn't.