Remove accidental System.Core.dll from CascadiaPackage #9153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug in VS 16.8 makes the WAP packaging project copy System.Core.dll from the CLR into all WAP packages. We don't need it, and it adds 300kb to our package (670kb uncompressed). VS 16.9 sets the AddAdditionalExplicitAssemblyReferences to suppress this assembly. If we do the same, we can avoid the reference *and* be eady for VS 16.9.
miniksa
approved these changes
Feb 14, 2021
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 2 hours 27 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
zadjii-msft
approved these changes
Feb 16, 2021
ghost
merged commit
DHowett
added a commit
that referenced
this pull request
Feb 23, 2021
A bug in VS 16.8 makes the WAP packaging project copy System.Core.dll from the CLR into all WAP packages. We don't need it, and it adds 300kb to our package (670kb uncompressed). VS 16.9 sets the AddAdditionalExplicitAssemblyReferences to suppress this assembly. If we do the same, we can avoid the reference *and* be eady for VS 16.9. (cherry picked from commit c1f8443)
|
🎉 Handy links: |
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug in VS 16.8 makes the WAP packaging project copy System.Core.dll
from the CLR into all WAP packages. We don't need it, and it adds 300kb
to our package (670kb uncompressed).
VS 16.9 sets the AddAdditionalExplicitAssemblyReferences to suppress
this assembly. If we do the same, we can avoid the reference and be
eady for VS 16.9.