Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure hyperlinks de-underline when pointer leaves terminal #9195

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Ensure hyperlinks de-underline when pointer leaves terminal #9195

merged 1 commit into from
Feb 17, 2021

Conversation

Don-Vito
Copy link
Contributor

@Don-Vito Don-Vito commented Feb 17, 2021 •
edited by DHowett
Loading

Introduced PointerExited handler to nullify last hovered cell
(which will also de-underline the hyperlink if required).

Closes #9141

@ghost ghost added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Impact-Visual It look bad. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels Feb 17, 2021
carlos-zamora
carlos-zamora approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@DHowett DHowett added the zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. label Feb 17, 2021
@DHowett DHowett changed the title Ensure hyperlinks de-underlined when pointer leaves terminal Ensure hyperlinks de-underline when pointer leaves terminal Feb 17, 2021
@DHowett DHowett merged commit 52d1533 into microsoft:main Feb 17, 2021
@DHowett
Copy link
Member

DHowett commented Feb 17, 2021

Thank you!

1 similar comment
@PhMajerus
Copy link

Thank you!

@DHowett DHowett added zStable-Service-Queued-1.12 A floating label that tracks the current Stable version for servicing purposes. and removed zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. zStable-Service-Queued-1.12 A floating label that tracks the current Stable version for servicing purposes. labels Feb 23, 2021
DHowett pushed a commit that referenced this pull request Feb 23, 2021
@Don-Vito @DHowett
Ensure hyperlinks de-underline when pointer leaves terminal (#9195)
ff126c5 
Introduced PointerExited handler to nullify last hovered cell
(which will also de-underline the hyperlink if required).

Closes #9141

(cherry picked from commit 52d1533)
@ghost
Copy link

ghost commented Mar 1, 2021

🎉Windows Terminal v1.6.10571.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Mar 1, 2021
Closed
@ghost
Copy link

ghost commented Mar 1, 2021

🎉Windows Terminal Preview v1.7.572.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Impact-Visual It look bad. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

De-underline hyperlink on hover-out #2
4 participants
@Don-Vito @DHowett @PhMajerus @carlos-zamora