-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a setting to flash the pane when BEL is emitted #9270
Merged
Merged
Changes from 6 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
370e0c0
initial
PankajBhojwani 3d7c9db
optional timer
PankajBhojwani 54a683d
add setting
PankajBhojwani b4ae30c
Merge branch 'main' of https://github.com/microsoft/terminal into dev…
PankajBhojwani d59a432
change timer
PankajBhojwani c1172cd
format
PankajBhojwani e0c9f89
stash, lock
PankajBhojwani e89f273
weak this
PankajBhojwani f93c9e8
Merge branch 'main' of https://github.com/microsoft/terminal into dev…
PankajBhojwani 4c125c3
resw, schema
PankajBhojwani 4b19b57
merge main, fix conflicts
PankajBhojwani 76c182a
use xaml light
PankajBhojwani 5ed7e93
spell
PankajBhojwani 678cfb5
er what
PankajBhojwani cecc6d8
Merge branch 'main' of https://github.com/microsoft/terminal into dev…
PankajBhojwani 23dc1fd
move light to own file
PankajBhojwani 9282a16
nits
PankajBhojwani eedb317
lazy load
PankajBhojwani 5b72726
some cleanup
PankajBhojwani 692ad14
animation
PankajBhojwani 8a42804
Format
PankajBhojwani b3c50f8
small changes
PankajBhojwani ab0ce5f
ahhh
PankajBhojwani 8026698
deprecate visual
PankajBhojwani fb27787
here and there
PankajBhojwani 2f9bc61
spell
PankajBhojwani 084ff79
fix crash, two-way binding
PankajBhojwani f1237d9
remove flag map
PankajBhojwani b675b2a
Cleanup
PankajBhojwani 6c9d8ef
== flag
PankajBhojwani 730cf09
Ternary
PankajBhojwani f5bb54e
Apply suggestions from code review
DHowett File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,10 +50,12 @@ JSON_ENUM_MAPPER(::winrt::Microsoft::Terminal::TerminalControl::ScrollbarState) | |
|
||
JSON_FLAG_MAPPER(::winrt::Microsoft::Terminal::Settings::Model::BellStyle) | ||
{ | ||
static constexpr std::array<pair_type, 4> mappings = { | ||
static constexpr std::array<pair_type, 6> mappings = { | ||
pair_type{ "none", AllClear }, | ||
pair_type{ "audible", ValueType::Audible }, | ||
pair_type{ "visual", ValueType::Visual }, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you want to fake deprecate "visual", you'll probably want to keep this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep! Though it now maps to |
||
pair_type{ "window", ValueType::Window }, | ||
pair_type{ "taskbar", ValueType::Taskbar }, | ||
pair_type{ "all", AllSet }, | ||
}; | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, the settings now look like this?
window
: flash terminaltaskbar
: add bell icon to tabvisual
=[ "window", "taskbar" ]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
taskbar
flashes the taskbar icon at the toolbar (if the terminal window is not focused)! The others are correct