Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show the context menu verb only when shift key is down #9358

Closed
wants to merge 2 commits into from
Closed

Show the context menu verb only when shift key is down #9358

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f140cdf
Show the context menu verb only when shift key is down
mooons Mar 3, 2021
8950298
Make verb display name consistent with "Open PowerShell window here"
mooons Mar 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/cascadia/ShellExtension/OpenTerminalHere.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
#include <ShlObj.h>

// TODO GH#6112: Localize these strings
static constexpr std::wstring_view VerbDisplayName{ L"Open in Windows Terminal" };
static constexpr std::wstring_view VerbDevBuildDisplayName{ L"Open in Windows Terminal (Dev Build)" };
static constexpr std::wstring_view VerbDisplayName{ L"Open Windows Terminal here" };
static constexpr std::wstring_view VerbDevBuildDisplayName{ L"Open Windows Terminal here (Dev Build)" };
static constexpr std::wstring_view VerbName{ L"WindowsTerminalOpenHere" };

// This code is aggressively copied from
Expand Down Expand Up @@ -103,7 +103,15 @@ HRESULT OpenTerminalHere::GetState(IShellItemArray* /*psiItemArray*/,
// We however don't need to bother with any of that, so we'll just return
// ECS_ENABLED.

*pCmdState = ECS_ENABLED;
// Show the verb only when shift key is down
if ((GetKeyState(VK_SHIFT) & 0x8000) != 0)
{
*pCmdState = ECS_ENABLED;
}
else
{
*pCmdState = ECS_HIDDEN;
}
return S_OK;
}

Expand Down