Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix selection logic with shift on multi-click and in mouse mode #9384

Closed
wants to merge 2 commits into from
Closed

Fix selection logic with shift on multi-click and in mouse mode #9384

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cca19d
Fix selection not to extend on multi-click
Don-Vito Mar 5, 2021
1aa147f
Introduce selection reset on anchor / same position click
Don-Vito Mar 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cascadia/TerminalControl/TermControl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1348,7 +1348,7 @@ namespace winrt::Microsoft::Terminal::TerminalControl::implementation
{
_HyperlinkHandler(_terminal->GetHyperlinkAtPosition(terminalPosition));
}
else if (shiftEnabled && _terminal->IsSelectionActive())
else if (shiftEnabled && mode == ::Terminal::SelectionExpansionMode::Cell && _terminal->IsSelectionActive())
{
// Shift+Click: only set expand on the "end" selection point
_terminal->SetSelectionEnd(terminalPosition, mode);
Expand Down