Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for renaming windows #9662

Merged
55 commits merged into from
Apr 2, 2021
Merged

Add support for renaming windows #9662

55 commits merged into from
Apr 2, 2021

Commits on Feb 25, 2021

  1. Rebase all the changes on main

      The history of this had gotten way, way too long. It included everything since I started working on this
    zadjii-msft committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    1c7da00 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    97818c6 View commit details
    Browse the repository at this point in the history
  3. fix tests

    zadjii-msft committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    2ec9415 View commit details
    Browse the repository at this point in the history
  4. Good ole Java

    zadjii-msft committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    e13e1e7 View commit details
    Browse the repository at this point in the history
  5. finish that test

    zadjii-msft committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    136ce6d View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2021

  1. macros are life

    zadjii-msft committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    ec97c43 View commit details
    Browse the repository at this point in the history
  2. 1 Configuration menu
    Copy the full SHA
    fa26f7f View commit details
    Browse the repository at this point in the history
  3. Plumb the events up and down

      WE LIVE IN A MAD WORLD. Teaching tips are exactly the UI we want, but they
      just don't fucking work man. WE want them to light dismiss, but if the window
      is inactive, and you have ILDE=true, then the tip immediately dismisses
      itself. So inactive windows need to not enable light dismiss.
    
      ALSO we need inactive windows to not focus something when the tip dismisses
      itself. Like, focus was _nowhere_ when we started. We need to toss the focus
      back to _nowhere_.
    zadjii-msft committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    a391455 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2021

  1. Configuration menu
    Copy the full SHA
    001f545 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9270e0f View commit details
    Browse the repository at this point in the history
  3. 1 Configuration menu
    Copy the full SHA
    1f0dceb View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2021

  1. Configuration menu
    Copy the full SHA
    99c2976 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c09b5e9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    aa51c07 View commit details
    Browse the repository at this point in the history
  4. 1 Configuration menu
    Copy the full SHA
    e818f8d View commit details
    Browse the repository at this point in the history
  5. THIS SHOULD GO TO THE PARENT BRANCH

    (cherry picked from commit aa51c07)
    zadjii-msft committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    e238daa View commit details
    Browse the repository at this point in the history
  6. THIS NEEDS TO GO TO THE PARENT

    (cherry picked from commit fa26f7f)
    zadjii-msft committed Mar 2, 2021
    1 Configuration menu
    Copy the full SHA
    27d12a2 View commit details
    Browse the repository at this point in the history
  7. 1 Configuration menu
    Copy the full SHA
    9d6f47f View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2021

  1. feedback from review

    zadjii-msft committed Mar 4, 2021
    2 Configuration menu
    Copy the full SHA
    c202257 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. initial review feedback

    zadjii-msft committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    eaaa204 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'origin/main' into dev/migrie/f/name-win…

    …dows-3
    
    # Conflicts:
    #	src/cascadia/Remoting/FindTargetWindowArgs.h
    #	src/cascadia/Remoting/ProposeCommandlineResult.h
    zadjii-msft committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    9f54229 View commit details
    Browse the repository at this point in the history
  3. Address PR concerns

      add a test, and add liberal comments.
    zadjii-msft committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    bba09e3 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. Merge branch 'dev/migrie/f/name-windows-3' into dev/migrie/f/identify…

    …Windows
    
    # Conflicts:
    #	src/cascadia/Remoting/WindowManager.cpp
    #	src/cascadia/TerminalApp/Resources/en-US/Resources.resw
    zadjii-msft committed Mar 17, 2021
    1 Configuration menu
    Copy the full SHA
    0799a19 View commit details
    Browse the repository at this point in the history
  2. That's better

    zadjii-msft committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    1105328 View commit details
    Browse the repository at this point in the history
  3. Cleanup for review

    zadjii-msft committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    97b4935 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    765c969 View commit details
    Browse the repository at this point in the history
  5. Merge branch 'dev/migrie/f/identifyWindows' into dev/migrie/f/rename-…

    …windows
    
    # Conflicts:
    #	src/cascadia/TerminalApp/Resources/en-US/Resources.resw
    #	src/cascadia/TerminalApp/TerminalPage.cpp
    #	src/cascadia/TerminalApp/TerminalPage.h
    #	src/cascadia/WindowsTerminal/AppHost.cpp
    zadjii-msft committed Mar 17, 2021
    1 Configuration menu
    Copy the full SHA
    e8edc71 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b66503c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b7703d2 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d035e50 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2021

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/f/identify…

    …Windows
    
    # Conflicts:
    #	src/cascadia/TerminalApp/AppLogic.cpp
    #	src/cascadia/TerminalApp/TerminalPage.cpp
    #	src/cascadia/TerminalApp/TerminalPage.h
    zadjii-msft committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    d64aa61 View commit details
    Browse the repository at this point in the history
  2. I'm overcomplicating this

    zadjii-msft committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    8b6e0bc View commit details
    Browse the repository at this point in the history
  3. Revert "I'm overcomplicating this"

    This reverts commit 8b6e0bc.
    zadjii-msft committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    7c775d5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b1b94f6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    31cb1b7 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2021

  1. This will make @DHowett happy

    zadjii-msft committed Mar 26, 2021
    1 Configuration menu
    Copy the full SHA
    5904c58 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2021

  1. Merge remote-tracking branch 'origin/dev/migrie/f/identifyWindows' in…

    …to dev/migrie/f/rename-windows
    zadjii-msft committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    ee3b87b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2ff4c60 View commit details
    Browse the repository at this point in the history
  3. runformat

    zadjii-msft committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    ff2ce4b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a9a0f06 View commit details
    Browse the repository at this point in the history
  5. runxamlformat

    zadjii-msft committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    3dab6ad View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2c1f468 View commit details
    Browse the repository at this point in the history
  7. This fixes part of the tests

      Broadly, the tests were broken by #7489 because there were no _startupActions. They relied on the removed codepath that assumed wt.exe always set actions, or `AppCommandlineArgs::ValidateStartupCommands` created one by default.
    
      These tests are still broken:
      * `TerminalAppLocalTests::TabTests::TryZoomPane [Failed]`
      * `TerminalAppLocalTests::TabTests::MoveFocusFromZoomedPane [Failed]`
      * `TerminalAppLocalTests::TabTests::CloseZoomedPane [Failed]`
    
      Re:#9659
    zadjii-msft committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    06b4168 View commit details
    Browse the repository at this point in the history
  8. Make the comments clearer

    zadjii-msft committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    205eee7 View commit details
    Browse the repository at this point in the history
  9. 1 Configuration menu
    Copy the full SHA
    673149c View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    4d66517 View commit details
    Browse the repository at this point in the history
  11. 1 Configuration menu
    Copy the full SHA
    f76de3c View commit details
    Browse the repository at this point in the history
  12. 1 Configuration menu
    Copy the full SHA
    d7dd615 View commit details
    Browse the repository at this point in the history
  13. 1 Configuration menu
    Copy the full SHA
    1664737 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    53adc15 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    e0ea241 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2021

  1. Configuration menu
    Copy the full SHA
    e207f4e View commit details
    Browse the repository at this point in the history
  2. nits for carlos

    zadjii-msft committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    edff3bb View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2021

  1. Nits for dustin

    zadjii-msft committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    631d3ed View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    312db84 View commit details
    Browse the repository at this point in the history