-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manually handle Enter and Escape in the Window Renamer #9730
Conversation
if (e.OriginalKey() == Windows::System::VirtualKey::Enter) | ||
{ | ||
// User is done making changes, close the rename box | ||
_WindowRenamerActionClick(sender, nullptr); | ||
} | ||
else if (e.OriginalKey() == Windows::System::VirtualKey::Escape) | ||
{ | ||
// User wants to discard the changes they made | ||
WindowRenamerTextBox().Text(WindowName()); | ||
WindowRenamer().IsOpen(false); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need an e.Handled(true);
for each of these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meh maybe? Doesn't seem like these bubble up to anyone else but I can roll it
@msftbot merge this in 1 minute |
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
Summary of the Pull Request
In exactly the same fashion as the tab renamer, handle Enter for committing the rename, and Escape for dismissing the rename.
References
PR Checklist
Validation Steps Performed
Played with it - this feels good.