Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent the virtual viewport bottom being moved up unintentionally #9770

Merged
4 commits merged into from
Apr 15, 2021
Merged

Prevent the virtual viewport bottom being moved up unintentionally #9770

4 commits merged into from
Apr 15, 2021

Commits on Apr 10, 2021

  1. Only move the virtual bottom down, unless it's outside the buffer range.

    @j4james
    j4james committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    c4b8153 View commit details
    Browse the repository at this point in the history

  2. Reset the virtual bottom when the scrollback is erased.

    @j4james
    j4james committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    c6897db View commit details
    Browse the repository at this point in the history

  3. Make sure the virtual bottom is reset when necessary in ScreenBufferT… 

    …ests.
    @j4james
    j4james committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    87e74e4 View commit details
    Browse the repository at this point in the history

  4. Add unit test to verify the virtual bottom doesn't move up.

    @j4james
    j4james committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    19f63dc View commit details
    Browse the repository at this point in the history