Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(activator): onboard new resource/data-source #256

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DariuszPorowski
Copy link
Member

📥 Pull Request

❓ What are you trying to address

  • Add new resource fabric_activator
  • Add new data-source fabric_activator
  • Add new data-source fabric_activators
  • Fix: missing preview note in data-source lists documentation
  • Misc: simplifies the code for IsPreviewMode

Copy link

github-actions bot commented Feb 14, 2025

Changelog Preview

v0.1.0-dev - February 18, 2025

✨ Added

  • #256 Onboard new resource/data-source fabric_activator (also known as reflex).

🪲 Fixed

  • #256 Missing preview note in list data-sources

Copy link

github-actions bot commented Feb 14, 2025

Code Coverage

Package Line Rate Complexity Health
github.com/microsoft/terraform-provider-fabric/internal/auth 89% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/customtypes 75% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/planmodifiers 69% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/typeutils 63% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/validators 80% 0
github.com/microsoft/terraform-provider-fabric/internal/functions 72% 0
github.com/microsoft/terraform-provider-fabric/internal/pkg/fabricitem 82% 0
github.com/microsoft/terraform-provider-fabric/internal/pkg/transforms 64% 0
github.com/microsoft/terraform-provider-fabric/internal/pkg/utils 83% 0
github.com/microsoft/terraform-provider-fabric/internal/provider 85% 0
github.com/microsoft/terraform-provider-fabric/internal/provider/client 70% 0
github.com/microsoft/terraform-provider-fabric/internal/provider/config 100% 0
github.com/microsoft/terraform-provider-fabric/internal/provider/utils 69% 0
github.com/microsoft/terraform-provider-fabric/internal/services/activator 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/capacity 87% 0
github.com/microsoft/terraform-provider-fabric/internal/services/dashboard 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/datamart 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/datapipeline 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/domain 42% 0
github.com/microsoft/terraform-provider-fabric/internal/services/environment 87% 0
github.com/microsoft/terraform-provider-fabric/internal/services/eventhouse 93% 0
github.com/microsoft/terraform-provider-fabric/internal/services/eventstream 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/kqldashboard 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/kqldatabase 82% 0
github.com/microsoft/terraform-provider-fabric/internal/services/kqlqueryset 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/lakehouse 86% 0
github.com/microsoft/terraform-provider-fabric/internal/services/mirroredwarehouse 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/mlexperiment 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/mlmodel 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/notebook 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/paginatedreport 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/report 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/semanticmodel 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/spark 75% 0
github.com/microsoft/terraform-provider-fabric/internal/services/sparkjobdefinition 92% 0
github.com/microsoft/terraform-provider-fabric/internal/services/sqlendpoint 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/warehouse 92% 0
github.com/microsoft/terraform-provider-fabric/internal/services/workspace 78% 0
Summary 76% (4198 / 5533) 0

Minimum allowed line rate is 40%

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 84.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 79.31%. Comparing base (b1a8416) to head (816e21b).

Files with missing lines Patch % Lines
internal/pkg/fabricitem/data_item.go 50.00% 1 Missing ⚠️
internal/pkg/fabricitem/data_item_definition.go 50.00% 1 Missing ⚠️
.../pkg/fabricitem/data_item_definition_properties.go 50.00% 1 Missing ⚠️
internal/pkg/fabricitem/data_item_properties.go 50.00% 1 Missing ⚠️
internal/pkg/fabricitem/data_items.go 66.66% 1 Missing ⚠️
internal/pkg/fabricitem/data_items_properties.go 50.00% 1 Missing ⚠️
internal/pkg/fabricitem/resource_item.go 50.00% 1 Missing ⚠️
...item/resource_item_config_definition_properties.go 50.00% 1 Missing ⚠️
.../pkg/fabricitem/resource_item_config_properties.go 50.00% 1 Missing ⚠️
...nternal/pkg/fabricitem/resource_item_definition.go 50.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
+ Coverage   79.22%   79.31%   +0.09%     
==========================================
  Files         156      159       +3     
  Lines       13382    13384       +2     
==========================================
+ Hits        10602    10616      +14     
+ Misses       2775     2763      -12     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badeamarjieh
Copy link
Member

Activator/Reflex do not support SPN as per the docs. In that case they wouldn't be supported at all here no?

@DariuszPorowski
Copy link
Member Author

Activator/Reflex do not support SPN as per the docs. In that case they wouldn't be supported at all here no?

@badeamarjieh That's the reason we have preview flag here and skip TestAcc tests until Activator team enable SPN support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants